Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_branch_name() bottleneck #159

Closed
extrawurst opened this issue Jun 29, 2020 · 1 comment
Closed

get_branch_name() bottleneck #159

extrawurst opened this issue Jun 29, 2020 · 1 comment
Assignees
@extrawurst
Labels
bug Something isn't working
Milestone
v0.8

Comments

@extrawurst
Copy link
Owner

extrawurst commented Jun 29, 2020 •
edited
Loading

turns out in a gigantic repo like chromium even get_branch_name needs to be either async or not called on every update since it takes ~35ms
@extrawurst extrawurst added the bug Something isn't working label Jun 29, 2020
@extrawurst extrawurst added this to the v0.8 milestone Jun 29, 2020
@extrawurst extrawurst self-assigned this Jun 29, 2020
@extrawurst extrawurst mentioned this issue Jul 4, 2020
Closed
@extrawurst
Copy link
Owner Author

released in 0.8 now: https:/extrawurst/gitui/releases/tag/v0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@extrawurst extrawurst

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.8
Development

No branches or pull requests
1 participant
@extrawurst