Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--remove-script isn't removing cron, logrotate and man file #102

Closed
reneschuster opened this issue Apr 16, 2016 · 5 comments
Closed

--remove-script isn't removing cron, logrotate and man file #102

reneschuster opened this issue Apr 16, 2016 · 5 comments

Comments

@reneschuster
Copy link
Contributor

Here the error:

     ....
     Removed file: /var/lib/clamav-unofficial-sigs/gpg-key/ss-keyring.gpg
     Removed file: /var/lib/clamav-unofficial-sigs/gpg-key/ss-keyring.gpg~
     Removed file: /var/lib/clamav-unofficial-sigs/gpg-key/trustdb.gpg
     Removed file: /var/log/clamav-unofficial-sigs/clamav-unofficial-sigs.log
     Removed file: /var/lib/clamav-unofficial-sigs/configs/purge.txt
rm: cannot remove ‘/’: Is a directory
     Removed file: /
rm: cannot remove ‘/’: Is a directory
     Removed file: /
rm: cannot remove ‘/’: Is a directory
     Removed file: /
     Removed script working directories: /var/lib/clamav-unofficial-sigs
     ....

The variables are not available when running --remove-script:

$cron_dir
$cron_filename
$logrotate_dir
$logrotate_filename
$man_dir
$man_filename
@marcin-github
Copy link

Installing and uninstalling should be done by package manager. Do one thing and do it well.
MrMEEE/bumblebee-Old-and-abbandoned#123
ValveSoftware/steam-for-linux#3671

@nerijus
Copy link

nerijus commented Apr 16, 2016

@extremeshok
Copy link
Owner

I only run -rf for the workdir, which should be assigned correctly, or the script wont function.

I will add some extra noob protections to make sure the path is more than 1 layer deep and contains something specific to the workdir.

@IdahoPL
Copy link
Contributor

IdahoPL commented Apr 16, 2016

+1 to what @marcin-github said. Leave installing and uninstalling to package managers, they will do it properly and with tracking all files.

@extremeshok
Copy link
Owner

Added some changes in 5.2.2.

Agree with management either via packages or configuration management.

Unfortunately some users still want the legacy --remove_script option. If the pgk_ options are defined the remove_script is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants