Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNN first order extensions #158

Merged
merged 5 commits into from
Jun 9, 2021
Merged

RNN first order extensions #158

merged 5 commits into from
Jun 9, 2021

Conversation

schaefertim
Copy link
Contributor

Add support for all first order extensions for RNN.
The axis_batch variable is removed from test problems in extensions.
Instead, modules Permute and ReduceTuple are introduced and can be used in a Sequential module.
Python version bumped to 3.7 because from __future__ import annotations is used.

f-dangel
f-dangel reviewed Jun 8, 2021
View reviewed changes
fully_documented.txt Outdated Show resolved Hide resolved
f-dangel
f-dangel reviewed Jun 8, 2021
View reviewed changes
fully_documented.txt Outdated Show resolved Hide resolved
f-dangel
f-dangel reviewed Jun 8, 2021
View reviewed changes
fully_documented.txt Outdated Show resolved Hide resolved
@f-dangel
Copy link
Owner

f-dangel commented Jun 9, 2021

Regarding Drop in coverage: This is due to the if TYPE_CHECKING blocks. Can you try the following approach? Should look something like this.

@f-dangel f-dangel merged commit a01d47a into f-dangel:rnn Jun 9, 2021
@schaefertim schaefertim deleted the rnn-firstorder branch June 14, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-dangel f-dangel f-dangel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schaefertim @f-dangel