Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Increase tests coverage to 60% #49

Merged
merged 4 commits into from
Jul 24, 2020
Merged

Increase tests coverage to 60% #49

merged 4 commits into from
Jul 24, 2020

Conversation

fabasoad
Copy link
Owner

Closes #45

Pull request checklist

Please check if your PR fulfills the following requirements:

  • I have read the CONTRIBUTING doc.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been reviewed and added / updated if needed (for bug fixes / features).
  • Build (dotnet build) was run locally and any changes were pushed for failures / warnings.
  • Tests (dotnet test) has passed locally and any fixes were made for failures.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Tests coverage < 60%

What is the new behavior?

Tests coverage > 60%

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@fabasoad fabasoad added the enhancement New feature or request label Jul 24, 2020
@fabasoad fabasoad added this to the v2.0.3 milestone Jul 24, 2020
@fabasoad fabasoad self-assigned this Jul 24, 2020
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #49 into main will increase coverage by 10.37%.
The diff coverage is 79.31%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #49       +/-   ##
===========================================
+ Coverage   50.09%   60.45%   +10.37%     
===========================================
  Files          28       29        +1     
  Lines         571      574        +3     
  Branches       59       59               
===========================================
+ Hits          286      347       +61     
+ Misses        284      227       -57     
+ Partials        1        0        -1     
Flag Coverage Δ
#unittests 60.45% <79.31%> (+10.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Ghacu.Api/Entities/WorkflowFile.cs 100.00% <ø> (ø)
src/Ghacu.GitHub/GitHubClient.cs 0.00% <0.00%> (ø)
src/Ghacu.Runner/Cli/CliService.cs 0.00% <ø> (ø)
src/Ghacu.Runner/Cli/Print/ActionPrinterBase.cs 0.00% <ø> (ø)
src/Ghacu.Runner/GlobalConfig.cs 0.00% <0.00%> (ø)
src/Ghacu.Runner/Program.cs 0.00% <0.00%> (ø)
src/Ghacu.Api/Entities/Version.cs 100.00% <100.00%> (+15.79%) ⬆️
src/Ghacu.Api/Entities/WorkflowInfo.cs 100.00% <100.00%> (+70.83%) ⬆️
src/Ghacu.GitHub/GitHubVersionProvider.cs 100.00% <100.00%> (ø)
src/Ghacu.Workflow/Exceptions/WorkflowException.cs 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b6c93...5043fb3. Read the comment docs.

@fabasoad fabasoad merged commit f1afa20 into main Jul 24, 2020
@fabasoad fabasoad deleted the feature/45 branch July 24, 2020 06:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase tests coverage to 60%
1 participant