Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendored modules in favour of go mod. #951

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Remove vendored modules in favour of go mod. #951

merged 1 commit into from
Sep 2, 2024

Conversation

tristanmorgan
Copy link
Member

I believe this is the currently accepted best method for managing dependancies in Go. It should open the possibility for Dependabot and easier updates.

aaronhurt
aaronhurt approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@aaronhurt aaronhurt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a point in time where some vendored code was only contained in the vendor folder and was not available via a public repo. That looks to have changed. I agree this change reflects community best practice.

@tristanmorgan tristanmorgan merged commit ccb2e62 into fabiolb:master Sep 2, 2024
2 checks passed
@tristanmorgan tristanmorgan deleted the remove_vendor branch September 2, 2024 23:06
@tristanmorgan tristanmorgan mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronhurt aaronhurt aaronhurt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristanmorgan @aaronhurt