Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Wrong Jib output directory in Maven multi-module build #1737

Closed
erikgb opened this issue Oct 17, 2019 · 4 comments
Closed

Wrong Jib output directory in Maven multi-module build #1737

erikgb opened this issue Oct 17, 2019 · 4 comments

Comments

@erikgb
Copy link
Contributor

erikgb commented Oct 17, 2019

Description

For a multi-module Maven build the Jib output directory is wrong.

Given the following Maven multi-module setup:

.
|— a
|— b

Actual behavior; The Jib Docker tarballs are created in ./target:

.
|— a
|— b
|— target
   |—docker
     |— a.tar
     |— b.tar         

Expected behavior; , The Jib Docker tarballs are created in ./a/target and ./b/target

.
|— a
   |— target
      |—docker
        |— a.tar

|— b
   |— target
      |—docker
        |— b.tar         

Info

  • f-m-p version : 4.3.0 (and HEAD of master 17.10.2019)
  • Maven version (mvn -v) : 3.5.3
@erikgb
Copy link
Contributor Author

erikgb commented Oct 17, 2019

I can create a sample project if that would be helpful, but I think the bug is quite easy to fix. I suspect this line:

TarImage tarImage = TarImage.named(targetImage).saveTo(Paths.get(outputDir + "/" + imageTarName));

@rohanKanojia
Copy link
Member

@erikgb : Thanks for noticing, Could you please add a PR for this?

@erikgb
Copy link
Contributor Author

erikgb commented Oct 17, 2019

@rohanKanojia : Can do. When is the cutoff for version 4.3.1? ;-)

@rohanKanojia
Copy link
Member

I am planning to do it tomorrow :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants