This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Fix #1706: Add support for configuration of prometheus.io/path annota… #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erikgb : Thanks, could you please add a line to CHANGELOG regarding this change? |
rohanKanojia
added
the
pr/changelog-entry-please
Codecov Report
@@ Coverage Diff @@
## master #1707 +/- ##
============================================
+ Coverage 33.84% 33.98% +0.13%
Complexity 1105 1105
============================================
Files 189 189
Lines 10690 10712 +22
Branches 1741 1745 +4
============================================
+ Hits 3618 3640 +22
Misses 6650 6650
Partials 422 422 |
Codecov Report
@@ Coverage Diff @@
## master #1707 +/- ##
============================================
+ Coverage 33.93% 33.98% +0.04%
Complexity 1105 1105
============================================
Files 189 189
Lines 10704 10712 +8
Branches 1744 1745 +1
============================================
+ Hits 3632 3640 +8
Misses 6650 6650
Partials 422 422 |
erikgb
force-pushed
the
pr/issue1708
branch
from
7fb037e
to
f9a3402
Compare
@rohanKanojia : I have added a line in CHANGELOG about this change |
oscerd
approved these changes
Sep 12, 2019
rohanKanojia
removed
the
pr/changelog-entry-please
devang-gaur
added
the
jkube/pending
devang-gaur
force-pushed
the
pr/issue1708
branch
from
feb1b55
to
65ed9a7
Compare
devang-gaur
approved these changes
Sep 19, 2019
rohanKanojia
added a commit
to rohanKanojia/jshift
that referenced
this pull request
Sep 26, 2019
rohanKanojia
removed
the
jkube/pending
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Nov 6, 2019
…o/path annotation Ported PR fabric8io/fabric8-maven-plugin#1707
rohanKanojia
added a commit
to eclipse-jkube/jkube
that referenced
this pull request
Nov 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion