Add support for report filtering #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test errors are due to the workflow running "composer update", not sure the fix belongs in this PR |
|
@AlexVanderbist could the same be merged here? |
|
Hi again @Jellyfrog, thanks for backporting this fix! Will tag it in a minute. |
Jellyfrog
added a commit
to Jellyfrog/flare-client-php-1
that referenced
this pull request
Aug 23, 2022
Current code will populate Flare::sentReports() even if it's filtered since the return from sendReportToApi() is not used: $this->sendReportToApi($report); return $report; This is a regression from facade#33
Jellyfrog
added a commit
to Jellyfrog/flare-client-php-1
that referenced
this pull request
Aug 23, 2022
Current code will populate Flare::sentReports() even if it's filtered since the return from sendReportToApi() is not used: $this->sendReportToApi($report); return $report; This is a regression from facade#33
Jellyfrog
added a commit
to Jellyfrog/flare-client-php-1
that referenced
this pull request
Aug 23, 2022
Current code will populate Flare::sentReports() even if it's filtered since the return from sendReportToApi() is not used: $this->sendReportToApi($report); return $report; This is a regression from facade#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to prevent reports from being sent.
The motivation behind it that we need a way to dynamically allow/disallow reports from being sent, for example based on user preferences since we plan on introducing this on self hosted project(librenms).
(setting
flare.keyto null does nothing since the Client instance is setup on boot already)Compared to
filterExceptionsCallableit can also prevent logs and errors from being sent, and that's why it's insendReportToApi()instead ofshouldSendReport()Usage is something like this: