Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies and CI #158

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bump dependencies and CI #158

wants to merge 3 commits into from

Conversation

andreasabel
Copy link

@andreasabel andreasabel commented Nov 1, 2023

  • include latest GHCs in CI
  • latest minor version is determined by haskell-actions/setup
  • freeze file is a bad cache key as it contains a time stamp,
    use the build plan instead (the correct choice)

Successful CI run at: https:/andreasabel/Haxl/actions/runs/6725224644

- include latest GHCs in CI
- latest minor version is determined by haskell-actions/setup
- freeze file is a bad cache key as it contains a time stamp,
  use the build plan instead (the correct choice)
@andreasabel
Copy link
Author

@simonmar : PR ready

@josefs
Copy link
Contributor

josefs commented Nov 13, 2023

Hi @andreasabel ! Thanks for the patch! Unfortunately it looks like it's broken for 9.4.

@andreasabel
Copy link
Author

@josefs: Thanks for taking a look!

Seems like this test breaks on 9.4: https:/facebook/Haxl/actions/runs/6725225214/job/18629935821?pr=158#step:8:150

:OutgoneFetchesTest:
  :finished: [Failed]
fetchesMap
expected: fromList []
 but got: fromList [("Sleep",fromList [(ConcurrentIOReq Sleep,1)])]

Here is the source:

outgoneFetchesTest :: String -> Int -> GenHaxl () () a -> Test
outgoneFetchesTest label unfinished haxl = TestLabel label $ TestCase $ do
env <- testEnv
_ <- timeout (100*1000) $ runHaxl env haxl -- 100ms
actual <- getMapFromRCMap <$> readIORef (submittedReqsRef env)
assertEqual "fetchesMap" expected actual
where
expected = if unfinished == 0 then Map.empty else
Map.singleton (dataSourceName (Proxy :: Proxy (ConcurrentIOReq Sleep))) $
Map.singleton (typeOf1 (undefined :: ConcurrentIOReq Sleep a)) unfinished
tests :: Test
tests = TestList
[ outgoneFetchesTest "finished" 0 $ do
-- test that a completed datasource fetch doesn't show up in Env
_ <- sleep 1 -- finished
_ <- sleep 1 -- cached/finished
_ <- sleep 1 -- cached/finished
wombats

I can see timeouts and sleeps here...

Let me boldly claim that nothing is wrong with my PR but something is wrong with this test...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants