npm run eject silently fails when a config folder already exist

[ugogo]

Description

npm run eject silently fails when a config folder already exist.

Expected behavior

It's a common behavior to have a /config folder at the base of a project.
npm run eject should throw an error or even better, "merge" new files with existing ones.

Actual behavior

➜  react-starter git:(master) mkdir config
➜  react-starter git:(master) npm run eject

> react-scripts eject

Are you sure you want to eject? This action is permanent. [y/N]
y
Ejecting...
➜  react-starter git:(master)

Environment

node -v: 5.0.0
npm -v: 3.3.6
Operating system: macOS Sierra

Reproducible Demo

• Clone the repo
• mkdir config
• npm run eject

Thanks 🙏

[gaearon]

I think this was fixed in #951, but it's not released yet.

[ugogo]

It seems that those checks are focused on files inside the folder, but doesn't check the folder itself?

[gaearon]

Can you check if it's reproducible on master?

[ugogo]

Noob question but, how could I do that?

According to NPM documentation, I tried this

"devDependencies": {
    "react-scripts": "git:/facebookincubator/create-react-app.git"
  }

but doesn't work Could not install /var/folders/………

[gaearon]

This wouldn't work. You'd need to follow the Contributing guide in the repo to test changes.

[ugogo]

> react-scripts eject

Are you sure you want to eject? This action is permanent. [y/N]
y
Ejecting...
`config` already exists in your app folder. We cannot continue as you would lose all the changes in that file or directory. Please move or delete it (maybe make a copy for backup) and run this command again.

npm ERR! Darwin 16.1.0
…

All's good, thanks 👍

[moffsugita]

Me too where is the file??
config already exists in your app folder.