Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added e2e test for checking typescript template with unsupported node #7844

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

awaseem
Copy link
Contributor

@awaseem awaseem commented Oct 18, 2019

Another subset of #7839

I added some e2e tests based on the following bash script: e2e-old-node.sh. I tested it on my local machine and I hope it runs as apart of the changes made to azure-pipelines.yml

The test just installs node version 8.9.x and ensures that the code errors out

@iansu
Copy link
Contributor

iansu commented Oct 18, 2019

I'm not sure why the build didn't run on this. @ianschmitz any ideas?

@awaseem
Copy link
Contributor Author

awaseem commented Oct 19, 2019

Oh I think it just took some time, but it just ran (and passed!)

@stale
Copy link

stale bot commented Nov 18, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Nov 18, 2019
@iansu iansu removed the stale label Nov 18, 2019
@iansu
Copy link
Contributor

iansu commented Nov 18, 2019

We'd still like to merge this. Can you fix the conflicts?

@awaseem
Copy link
Contributor Author

awaseem commented Nov 18, 2019

@iansu of course!!! can get it done EOD

@awaseem
Copy link
Contributor Author

awaseem commented Nov 18, 2019

@iansu should be good to go, my new tests passed on the build pipeline

@iansu iansu added this to the 3.3 milestone Nov 18, 2019
@iansu iansu merged commit 4b4f3f2 into facebook:master Nov 18, 2019
@iansu
Copy link
Contributor

iansu commented Nov 18, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators Nov 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants