Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support source maps for scss in dev environments #8638

Merged
merged 1 commit into from
May 4, 2020

Conversation

MKorostoff
Copy link
Contributor

This should resolve #5707. A basic history of that issue as I understand it: currently, create-react-app doesn't have sourcemaps for scss on development environments. This feature was briefly added two years ago in #5713, then reverted due to a bug in an upstream dependency. The upstream bug is now fixed, so we can (I believe) re-enable this feature.

@facebook-github-bot
Copy link

Hi @MKorostoff!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@MKorostoff
Copy link
Contributor Author

@facebook-github-bot not sure if anyone will receive this message, but I've completed the form you requested.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@chybisov
Copy link
Contributor

chybisov commented Apr 2, 2020

Any updates on this?

@stale
Copy link

stale bot commented May 2, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label May 2, 2020
@iryan2
Copy link

iryan2 commented May 2, 2020

Bump

@stale stale bot removed the stale label May 2, 2020
@ianschmitz ianschmitz added this to the 4.0 milestone May 3, 2020
@ianschmitz ianschmitz merged commit b37cff9 into facebook:master May 4, 2020
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-react-app sass sourcemaps not working
5 participants