Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump update-notifier #8660

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

layershifter
Copy link
Contributor

@layershifter layershifter commented Feb 13, 2023

Motivation

An attempt to bump update-notifier (similar to #7684).

The fix for imports arrived in Yarn 3.2.4 (yarnpkg/berry#4862), that was a blocker before #7684 (comment).

# yarn -v
3.4.1

# yarn config get nodeLinker 
pnp

# yarn node     
Welcome to Node.js v16.14.0.
Type ".help" for more information.
> (await import('chalk')).colors
[
  'black',           'red',            'green',
  'yellow',          'blue',           'magenta',
  'cyan',            'white',          'blackBright',
  'gray',            'grey',           'redBright',
  'greenBright',     'yellowBright',   'blueBright',
  'magentaBright',   'cyanBright',     'whiteBright',
  'bgBlack',         'bgRed',          'bgGreen',
  'bgYellow',        'bgBlue',         'bgMagenta',
  'bgCyan',          'bgWhite',        'bgBlackBright',
  'bgGray',          'bgGrey',         'bgRedBright',
  'bgGreenBright',   'bgYellowBright', 'bgBlueBright',
  'bgMagentaBright', 'bgCyanBright',   'bgWhiteBright'
]

Related issues/PRs

Fixes #8277.

@facebook-github-bot
Copy link
Contributor

Hi @layershifter!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Feb 13, 2023

[V2]

Name Link
🔨 Latest commit 53b8e9c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63ee73407248ca00088d72f3
😎 Deploy Preview https://deploy-preview-8660--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Feb 13, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 85 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 83 🟢 100 🟢 100 🟢 100 🟢 90 Report

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 13, 2023
@layershifter layershifter marked this pull request as ready for review February 13, 2023 14:04
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you commit the lockfile changes?

@layershifter
Copy link
Contributor Author

Could you commit the lockfile changes?

@Josh-Cena Oops, sorry missed that. As I see @slorber have already done that.

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Feb 17, 2023
@slorber slorber merged commit d98edcd into facebook:main Feb 17, 2023
@layershifter layershifter deleted the chore/bump-update-notifier branch February 17, 2023 10:20
@xnivaxhzne
Copy link

@slorber may I know when this change will get released? Asking because some changes merged before the date on which the current PR got merged were went in the release 2.4.0. I couldn't understand the release process.

@slorber
Copy link
Collaborator

slorber commented Apr 5, 2023

@kavinkuma6 all PRs target the upcoming v3 by default, unless we backport them to the v2 branch (and this one has not been backported)

You can use a canary release if you need this feature right now

@xnivaxhzne
Copy link

@kavinkuma6 all PRs target the upcoming v3 by default, unless we backport them to the v2 branch (and this one has not been backported)

You can use a canary release if you need this feature right now

Got it man. Thanks

@WikiRik WikiRik mentioned this pull request Jul 19, 2023
3 tasks
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Jul 21, 2023
This was referenced Oct 19, 2023
@slorber slorber removed the to backport This PR is planned to be backported to a stable version of Docusaurus label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@docusaurus/[email protected] depends on a deep dependency [email protected] which is a vulnerable version
5 participants