Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meru fw_util: config file changes #200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arajeev-ARISTA
Copy link

@arajeev-ARISTA arajeev-ARISTA commented May 31, 2024

Summary of Changes

  1. Use –noverify-all option with flashrom write.
    This would skip verification of regions not included in the layout file to improve performance.

  2. Leading zeros in the FW version numbers read through sysfs can cause them to be interpreted as octal numbers by shell. This change removes leading 0’s from the version numbers except when there is a ‘0x’ prefix. The sed commands to search and replace are written in a way that the leading 0’s are replaced only if the version number starts with a 0 followed by another digit.

  3. Remove spidev binding since it is no longer necessary as the spi driver already binds to spidev as specified by platform_manager

Testing

Verified fw upgrade/downgrade with fw_util

Change in programming time:
meru800bia smb_fpga:
real    4m55.654s => 0m55.890s
user    0m9.705s  => 0m9.748s
sys     2m55.965s => 0m26.562s

meru800bfa smb_fpga0:
real    4m57.611s => 0m58.643s
user    0m13.195s => 0m13.162s
sys     2m54.678s => 0m26.260s

- Use –noverify-all option with flashrom write
- Remove leading 0’s from the firmware version numbers
@facebook-github-bot
Copy link
Contributor

@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants