libmbfl failed to build

[kevinxucs]

On latest master, HHVM failed to build (on Ubuntu 14.04) because of one of the third party library libmbfl fails.

[  2%] Built target pcre
[  2%] Built target pcre_jit_test
[  2%] Built target pcrecpp
[  2%] Built target pcre_scanner_unittest
[  2%] Built target pcre_stringpiece_unittest
[  2%] Built target pcrecpp_unittest
[  2%] Built target pcreposix
[  2%] Built target pcregrep
[  3%] Built target pcretest
[  3%] Built target fastlz
[  3%] Built target afdt
[  3%] Building C object third-party/libmbfl/mbfl/CMakeFiles/mbfl.dir/mbfilter.c.o
/p/hhvm/third-party/libmbfl/mbfl/mbfilter.c: In function 'is_fullwidth':
/p/hhvm/third-party/libmbfl/mbfl/mbfilter.c:1757:10: error: 'mbfl_eaw_table' undeclared (first use in this function)
  if (c < mbfl_eaw_table[0].begin) {
          ^
/p/hhvm/third-party/libmbfl/mbfl/mbfilter.c:1757:10: note: each undeclared identifier is repo

So it turns out, after cmake . is run, all the content of the third-party/libmbfl/mbfl/eaw_table.h is erased, which is the cause of the compilation error.

[Majkl578]

I can confirm this, master was currently unbuildable, after git pull. But I was able to work around this by cleaning the tree, removing /third-party and recursively updating git submodules.

/build/hhvm/hhvm/third-party/libmbfl/mbfl/mbfilter.c:107:23: fatal error: eaw_table.h: No such file or directory
 #include "eaw_table.h"
                       ^
compilation terminated.
make[3]: *** [third-party/libmbfl/mbfl/CMakeFiles/mbfl.dir/mbfilter.c.o] Error 1
make[2]: *** [third-party/libmbfl/mbfl/CMakeFiles/mbfl.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....

[kevinxucs]

btw, the workaround for me is after running cmake, go to third-party, run git checkout -- .

[kevinxucs]

my problem was that awk command was linked to mawk, install gawk fixes the problem

[Majkl578]

This should be fixed by hhvm/hhvm-third-party@d53dc7a, right?