Pass resetCache option to jest-haste-map
#223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `resetCache` option is set on the bundler, it should also be passed to the `DependencyGraph` and `jest-haste-map` to clean up any cached files there.
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=======================================
Coverage 85.35% 85.35%
=======================================
Files 134 134
Lines 4391 4391
Branches 682 682
=======================================
Hits 3748 3748
Misses 572 572
Partials 71 71
Continue to review full report at Codecov.
|
|
Thanks! I'm landing this 👍 |
There was a problem hiding this comment.
rafeca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
resetCacheoption is set on the bundler, it should also be passed to theDependencyGraphandjest-haste-mapto clean up any cached files there.Summary
While trying to get
react-native-windowsworking against the[email protected]RC, I ran into a series of issues because thejest-haste-mapcache was not cleaned up when the--reset-cacheflag was set on thereact-nativeCLI. Not only was the option not being passed tometro(see facebook/react-native#20706), butmetrowas not passing theresetCacheoption to theDependencyGraphandjest-haste-map.Test plan
react-native-windows, where the problem was occurring. I had a case where if myhasteImplimplementation frommetro.config.jshad a bug. Even after fixing the bug, thejest-haste-mapwas cached with missing haste modules. Only after deleting that file could I get back to a state where the fixedmetro.config.jswould work. After making this change, using--reset-cachefrom thereact-nativeCLI could clear the haste map cache.