Skip to content

Commit

Permalink
Update comments to getViewManagerConfig() function name
Browse files Browse the repository at this point in the history
Summary: This change updates the comments and warning to match the function name.

Reviewed By: achen1

Differential Revision: D10345724

fbshipit-source-id: 05b1c60703da97ed083d7de492559bafb46ad813
  • Loading branch information
fatalsun authored and facebook-github-bot committed Oct 11, 2018
1 parent 6eeff75 commit b4a532e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Libraries/ReactNative/UIManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ if (__DEV__) {
get: () => {
console.warn(
`Accessing view manager configs directly off UIManager via UIManager['${viewManagerName}'] ` +
`is no longer supported. Use UIManager.getViewManager('${viewManagerName}') instead.`,
`is no longer supported. Use UIManager.getViewManagerConfig('${viewManagerName}') instead.`,
);
return UIManager.getViewManagerConfig(viewManagerName);
},
Expand Down
4 changes: 2 additions & 2 deletions Libraries/ReactNative/UIManagerProperties.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
*
* In an effort to improve startup performance by lazily loading view managers,
* the interface to access view managers will change from
* UIManager['viewManagerName'] to UIManager.getViewManager('viewManagerName').
* UIManager['viewManagerName'] to UIManager.getViewManagerConfig('viewManagerName').
* By using a function call instead of a property access, the UIManager will
* be able to initialize and load the required view manager from native
* synchronously. All of React Native's core components have been updated to
* use getViewManager(). For the next few releases, any usage of
* use getViewManagerConfig(). For the next few releases, any usage of
* UIManager['viewManagerName'] will result in a warning. Because React Native
* does not support Proxy objects, a view manager access is implied if any of
* UIManager's properties that are not one of the properties below is being
Expand Down

0 comments on commit b4a532e

Please sign in to comment.