-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting RCTRootView.appProperties in Objective-C has no effect #15938
Comments
@shaneosullivan did you find the answer? I'm having the similar issue: https://stackoverflow.com/questions/46808407/setting-rootview-appproperties-doesnt-re-render-root-component |
In my case, I think view is not re-rendered because https:/facebook/react-native/blob/master/React/Base/RCTRootView.m#L339 don't know whether it's bug or not, but at least I want to know the way around it. |
@notgiorgi I worked around it by moving from using |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions. |
Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
react-native -v
: 0.48.1node -v
: v7.2.0npm -v
:3.10.9yarn --version
: 0.18.0Then, specify:
iOS
macOS 10.12.4
XCode, issue is specific to iOS
Steps to Reproduce
Note: These are steps for using my example project. It's a long way of saying that setting the RCTRootView.appProperties has no effect, either in the viewDidLoad function or when I tried invoking it as the result of a NativeModule function call from JS. When debugging, the RCTRootView.m file was failing out at RCTAssertMainQueue(), but I don't know how to make that not fail.
Expected Behavior
The React Native view should update to show the URL provided to it. See the code here that sets the appProperties: https:/shaneosullivan/ReactNativeExampleBrowserExtension/compare/appPropertiesBug?expand=1#diff-0b1a9f46953a980a748dafea06f6543fR69
Actual Behavior
Nothing happens, the RN app is never re-rendered
Reproducible Demo
The 'appPropertiesBug' branch of https:/shaneosullivan/ReactNativeExampleBrowserExtension/ shows this error, as noted above.
The line in question that executes (I checked with the XCode debugger) but has no effect is https:/shaneosullivan/ReactNativeExampleBrowserExtension/compare/appPropertiesBug?expand=1#diff-0b1a9f46953a980a748dafea06f6543fR69
The text was updated successfully, but these errors were encountered: