-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.50.0] PrivateDatabase.{cpp,h} not included in Podspec #16663
Labels
Resolution: Locked
This issue was locked by the bot.
Comments
notjosh
changed the title
PrivateDatabase.{cpp,h} not included in Podspec
[0.50.0] PrivateDatabase.{cpp,h} not included in Podspec
Nov 3, 2017
This was referenced Nov 3, 2017
ide
pushed a commit
that referenced
this issue
Nov 4, 2017
Summary: Resolves #16663. Walked through the reproduction steps in #16663, but with successful build. We can also now see the files are included in the `Pods` project: <img width="236" alt="screen shot 2017-11-03 at 7 43 21 pm" src="https://user-images.githubusercontent.com/33126/32390596-4a06c05c-c0cf-11e7-8616-3ae547f8cca2.png"> (I noticed a subspec called `_ignore_me_subspec_for_linting_` so do we have tests for the podspec?) [IOS] [BUGFIX] [React.podspec] - Resolves build error about missing symbols for PrivateDatabase.{cpp,h} Closes #16664 Differential Revision: D6238178 Pulled By: hramos fbshipit-source-id: b57007ab8c7c8bd0faf1f2f11269a7a2c28183e5
ide
pushed a commit
that referenced
this issue
Nov 4, 2017
Summary: Resolves #16663. Walked through the reproduction steps in #16663, but with successful build. We can also now see the files are included in the `Pods` project: <img width="236" alt="screen shot 2017-11-03 at 7 43 21 pm" src="https://user-images.githubusercontent.com/33126/32390596-4a06c05c-c0cf-11e7-8616-3ae547f8cca2.png"> (I noticed a subspec called `_ignore_me_subspec_for_linting_` so do we have tests for the podspec?) [IOS] [BUGFIX] [React.podspec] - Resolves build error about missing symbols for PrivateDatabase.{cpp,h} Closes #16664 Differential Revision: D6238178 Pulled By: hramos fbshipit-source-id: b57007ab8c7c8bd0faf1f2f11269a7a2c28183e5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is this a bug report?
Yes.
Have you read the Contributing Guidelines?
Yes.
Environment
Steps to Reproduce
(bundle exec) pod install
to link everything back together with 0.50.0My
Podfile
uses these pods, in case it matters:Expected Behavior
Build should work
Actual Behavior
Build failure, with error:
Solution
I was able to resolve the issue by adding another section to the
React.podspec
:and then adding that to my
Podfile
.I'll create a PR with a fix: I think adding
PrivateDatabase
as a dependency forjschelpers
should solve the issue implicitly. But would like to use this issue to track it, in case there are any other issues as a result.The text was updated successfully, but these errors were encountered: