Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] Animated-test #21517

Closed
elicwhite opened this issue Oct 5, 2018 · 3 comments
Closed

[Flaky Test] Animated-test #21517

elicwhite opened this issue Oct 5, 2018 · 3 comments
Labels
API: Animated p: Facebook Partner: Facebook Partner Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot. 🔩Test Infrastructure Test infrastructure and continuous integration.

Comments

@elicwhite
Copy link
Member

Animated-test.js has been flaky and causing CI builds to fail. Here is an example: https://circleci.com/gh/facebook/react-native/55576?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

This test was also disabled automatically at Facebook due to flakiness:
Flakiness Score: 11%

FAIL  Libraries/Animated/src/__tests__/Animated-test.js
  ● Animated tests › Animated › send toValue when an underdamped spring stops

    Ran 100000 timers, and there are still more! Assuming we've hit an infinite recursion and bailing out...

      140 |       anim.addListener(listener);
      141 |       Animated.spring(anim, {toValue: 15}).start();
    > 142 |       jest.runAllTimers();
          |            ^
      143 |       const lastValue =
      144 |         listener.mock.calls[listener.mock.calls.length - 2][0].value;
      145 |       expect(lastValue).not.toBe(15);

      at FakeTimers.runAllTimers (node_modules/jest-util/build/fake_timers.js:195:13)
      at Object.<anonymous> (Libraries/Animated/src/__tests__/Animated-test.js:142:12)
@elicwhite
Copy link
Member Author

@janicduplessis, any ideas here?

@react-native-bot
Copy link
Collaborator

We are automatically closing this issue because it does not appear to follow any of the provided issue templates.

Please make use of the bug report template to let us know about a reproducible bug or regression in the core React Native library.

If you'd like to propose a change or discuss a feature request, there is a repository dedicated to Discussions and Proposals you may use for this purpose.

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. 📋No Template labels Oct 5, 2018
@elicwhite elicwhite reopened this Oct 5, 2018
@elicwhite elicwhite added 🔩Test Infrastructure Test infrastructure and continuous integration. ❌CI Test Failure and removed 📋No Template labels Oct 5, 2018
@hramos
Copy link
Contributor

hramos commented Oct 5, 2018

lol @react-native-bot (@TheSavior, I'll whitelist you from these)

facebook-github-bot pushed a commit that referenced this issue Oct 5, 2018
Summary:
This test is disabled internally and flaky in open source causing CI to fail. Skipping it for now.

Related to: #21517

Reviewed By: RSNara

Differential Revision: D10223498

fbshipit-source-id: 37a3798c0abb7de829bc5b59e02f23d8943da882
kelset pushed a commit that referenced this issue Oct 12, 2018
Summary:
This test is disabled internally and flaky in open source causing CI to fail. Skipping it for now.

Related to: #21517

Reviewed By: RSNara

Differential Revision: D10223498

fbshipit-source-id: 37a3798c0abb7de829bc5b59e02f23d8943da882
@hramos hramos removed the 🔶APIs label Jan 24, 2019
@hramos hramos closed this as completed Jan 26, 2019
@hramos hramos reopened this Jan 26, 2019
@hramos hramos added p: Facebook Partner: Facebook Partner and removed Core Team labels Mar 8, 2019
@cpojer cpojer closed this as completed Apr 8, 2019
t-nanava pushed a commit to microsoft/react-native-macos that referenced this issue Jun 17, 2019
Summary:
This test is disabled internally and flaky in open source causing CI to fail. Skipping it for now.

Related to: facebook#21517

Reviewed By: RSNara

Differential Revision: D10223498

fbshipit-source-id: 37a3798c0abb7de829bc5b59e02f23d8943da882
@facebook facebook locked as resolved and limited conversation to collaborators Apr 8, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API: Animated p: Facebook Partner: Facebook Partner Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot. 🔩Test Infrastructure Test infrastructure and continuous integration.
Projects
None yet
Development

No branches or pull requests

4 participants