Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds --port option to react-native run-ios as well as patches port … #16172

Closed
wants to merge 2 commits into from
Closed

adds --port option to react-native run-ios as well as patches port … #16172

wants to merge 2 commits into from

Commits on Jan 4, 2018

  1. # This is a combination of 6 commits. 

    # This is the 1st commit message:

adds --port option to `react-native run-ios` as well as patches port option with run-android to properly detect and start the packager

# This is the commit message facebook#2:

refactor iOS build to use preprocessor variable set from env variable; clean up sytle issues

# This is the commit message facebook#3:

add ifndef for default ports and change name of env var to RCT_METRO_PORT

# This is the commit message facebook#4:

move defines to RCTDefines.h

# This is the commit message facebook#5:

add new line

# This is the commit message facebook#6:

fix code formating issue
    Michael S. Kazmier committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    1dbe4fa View commit details
    Browse the repository at this point in the history

  2. adds --port option to react-native run-ios as well as patches port … 

    …option with run-android to properly detect and start the packager

refactor iOS build to use preprocessor variable set from env variable; clean up sytle issues

add ifndef for default ports and change name of env var to RCT_METRO_PORT

move defines to RCTDefines.h

add new line

fix code formating issue

checks for empty RCT_METRO_PORT define and replaces it with default

adds --port option to `react-native run-ios` as well as patches port option with run-android to properly detect and start the packager

refactor iOS build to use preprocessor variable set from env variable; clean up sytle issues

add ifndef for default ports and change name of env var to RCT_METRO_PORT

move defines to RCTDefines.h

add new line

fix code formating issue

checks for empty RCT_METRO_PORT define and replaces it with default
    Michael S. Kazmier committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    8251757 View commit details
    Browse the repository at this point in the history