Debug only code were leaking into release builds on iOS. #21232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ways defined, it is just rather 0 or 1.
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
react-native-bot
added
Platform: iOS
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 20, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dryganets merged commit d1ff0b0 into Once this commit is added to a release, you will see the corresponding version tag below the description at d1ff0b0. If the commit has a single |
kelset
pushed a commit
that referenced
this pull request
Sep 21, 2018
Summary: RCT_DEBUG is always defined - it is just rather 0 or 1 so ```#ifndef RCT_DEBUG is always true``` Pull Request resolved: #21232 Differential Revision: D9982316 Pulled By: hramos fbshipit-source-id: 5408bfcf95a6ed2beae38217a6ad1ee43950857d
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
) Summary: RCT_DEBUG is always defined - it is just rather 0 or 1 so ```#ifndef RCT_DEBUG is always true``` Pull Request resolved: facebook#21232 Differential Revision: D9982316 Pulled By: hramos fbshipit-source-id: 5408bfcf95a6ed2beae38217a6ad1ee43950857d
elicwhite
added
p: Microsoft
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCT_DEBUG is always defined - it is just rather 0 or 1 so
#ifndef RCT_DEBUG is always trueTest Plan:
No testing is needed it is minor typo fix.
Release Notes:
[MINOR] [IOS] [DEBUG] - Message