Remove PropTypes from MaskedViewIOS.ios.js #21346
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Generated by 🚫 dangerJS |
react-native-bot
added
Platform: iOS
| @@ -20,7 +18,7 @@ import type {ViewProps} from 'ViewPropTypes'; | |||
|
|
|||
| const RCTMaskedView = requireNativeComponent('RCTMaskedView'); | |||
|
|
|||
| type Props = { | |||
| type Props = $ReadOnly<{ | |||
There was a problem hiding this comment.
Should make it exact using |, like:
type Props = $ReadOnly<{|
//...
|}>;
| @@ -20,7 +18,7 @@ import type {ViewProps} from 'ViewPropTypes'; | |||
|
|
|||
| const RCTMaskedView = requireNativeComponent('RCTMaskedView'); | |||
|
|
|||
| type Props = { | |||
| type Props = $ReadOnly<{ | |||
| ...ViewProps, | |||
|
|
|||
| children: any, | |||
There was a problem hiding this comment.
children should be typed like this:
children?: React.Node,
|
Thank you for comments! I fixed by following your comments. |
|
Thanks, LGTM! 👍 |
|
Thanks for contributing! I can't import this yet because you don't have a valid CLA on file. You can follow the instructions from the facebook bot in this comment to complete the CLA |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@nd-02110114 merged commit 8487e8f into Once this commit is added to a release, you will see the corresponding version tag below the description at 8487e8f. If the commit has a single |
|
Thanks for contributing! |
hramos
removed
Import Started
Summary: related facebook#21342 This is a first PR for this repo. So, if there are any problem, please tell me 🙇 TODO * delete props types * apply read only interface CheckList - [x] `yarn prettier` - [x] `yarn flow-check-ios` Pull Request resolved: facebook#21346 Differential Revision: D10081962 Pulled By: TheSavior fbshipit-source-id: 32387c58f180b9aa5f854e323a4bb29aa73f04c8
related #21342
This is a first PR for this repo.
So, if there are any problem, please tell me 🙇
TODO
CheckList
yarn prettieryarn flow-check-ios