Move DeprecatedViewPropTypes to DeprecatedViewProps #21349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
42 tasks
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 27, 2018
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@empyrical merged commit 1b90908 into Once this commit is added to a release, you will see the corresponding version tag below the description at 1b90908. If the commit has a single |
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: This PR moves `DeprecatedViewPropTypes` to a new `DeprecatedViewProps` folder, and copies all documentation comments to the relevant Flow types file. Pull Request resolved: facebook#21349 Differential Revision: D10080802 Pulled By: TheSavior fbshipit-source-id: af4881f3b12e8a1e675b849e0fcf0cc57a68e57f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
DeprecatedViewPropTypesto a newDeprecatedViewPropsfolder, and copies all documentation comments to the relevant Flow types file.Test Plan:
All flow checks pass.
Release Notes:
[GENERAL] [ENHANCEMENT] [Libraries/Components/View/ViewPropTypes.js] - Copied documentation to here.
[GENERAL] [ENHANCEMENT] [DeprecatedViewPropTypes.js] - Relocated