Remove PropTypes from ElementProperties #21350
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Generated by 🚫 dangerJS |
| source?: { | ||
| fileName?: string, | ||
| lineNumber?: number, | ||
| style?: ?DangerouslyImpreciseStyleProp, |
There was a problem hiding this comment.
You should change this up, so instead of importing and using DangerouslyImpreciseStyleProp, it uses ViewStyleProp
|
Had a look at the flow failures and looks like a fix will need to be done;
frame?: ?Object,
selection?: ?number,
setSelection?: ?number => mixed,Frame is not well typed yet, so it can be stubbed out using |
react-native-bot
added
Missing Test Plan
|
LGTM! 👍 |
| lineNumber?: number, | ||
| style?: ?ViewStyleProp, | ||
| source?: ?{ | ||
| fileName?: ?string, |
There was a problem hiding this comment.
I'm not sure these should be nullable. Lets leave fileName and lineNumber the way they were:
fileName?: string,
lineNumber?: string
| }; | ||
| frame?: ?Object, | ||
| selection?: ?number, | ||
| setSelection?: (?number) => mixed, |
There was a problem hiding this comment.
setSelection is only ever called with a number, never with null, so the argument shouldn't be nullable. setSelection?: (number) => mixed
| @@ -24,29 +23,21 @@ const flattenStyle = require('flattenStyle'); | |||
| const mapWithSeparator = require('mapWithSeparator'); | |||
| const openFileInEditor = require('openFileInEditor'); | |||
|
|
|||
| import type {DangerouslyImpreciseStyleProp} from 'StyleSheet'; | |||
There was a problem hiding this comment.
prettier/prettier: Replace (number) with number
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@kdastan merged commit c650407 into Once this commit is added to a release, you will see the corresponding version tag below the description at c650407. If the commit has a single |
|
Thanks for contributing! |
hramos
removed
Import Started
Summary: Related to facebook#21342 Pull Request resolved: facebook#21350 Differential Revision: D10081454 Pulled By: TheSavior fbshipit-source-id: db27a1f23c643b7d6d73136254eff91625419583
Related to #21342