Split EdgeInsets in DeprecatedPropTypes and flow types #21351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@empyrical I'm not sure why flow-check is failing in CI, should I find all references of require('EdgeInsetsPropType'), replace with require('DeprecatedEdgeInsetsPropType') , and rename all to Deprecated ? |
|
I missed that flow failure, sorry!
const EdgeInsetsPropType = require('EdgeInsetsPropType');to this: const EdgeInsetsPropType = require('DeprecatedEdgeInsetsPropTypes'); |
elicwhite
reviewed
Sep 27, 2018
elicwhite
reviewed
Sep 27, 2018
There was a problem hiding this comment.
TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks for contributing! |
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: This PR splits EdgeInsetsPropTypes into EdgeInsetsPropTypes with only flow types and DeprecatedEdgeInsetsPropTypes inside DeprecatedProptypes with only PropTypes. Related to facebook#21342 Pull Request resolved: facebook#21351 Reviewed By: RSNara Differential Revision: D10081512 Pulled By: TheSavior fbshipit-source-id: 267a6fbb455e02dd7f2b0f3b59790e96387eaa09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits EdgeInsetsPropTypes into EdgeInsetsPropTypes with only flow types and DeprecatedEdgeInsetsPropTypes inside DeprecatedProptypes with only PropTypes.
Related to #21342
Test Plan:
All flow checks pass.
Release Notes:
[GENERAL] [ENHANCEMENT] [DeprecatedEdgeInsetsPropTypes.js] - Created.
[GENERAL] [ENHANCEMENT] [EdgeInsetsPropTypes.js] - Flow types only.