SwipeableFlatList, SwipeableQuickActions: Remove PropTypes #21384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 28, 2018
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@empyrical merged commit 9104b04 into Once this commit is added to a release, you will see the corresponding version tag below the description at 9104b04. If the commit has a single |
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…21384) Summary: Part of: facebook#21342 This PR removes the prop types for the components `SwipeableFlatList` and `SwipeableQuickActions`. The props for `SwipeableFlatList` have been left as not $ReadOnly, because it needs the types in `Libraries/Lists/*` to also be cleaned up. A todo notice has been added. Pull Request resolved: facebook#21384 Differential Revision: D10099694 Pulled By: TheSavior fbshipit-source-id: 424b900942c9a7889b664f351f79abee55923430
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #21342
This PR removes the prop types for the components
SwipeableFlatListandSwipeableQuickActions.The props for
SwipeableFlatListhave been left as not $ReadOnly, because it needs the types inLibraries/Lists/*to also be cleaned up. A todo notice has been added.Test Plan:
Flow checks pass.
Release Notes:
[GENERAL] [ENHANCEMENT] [Libraries/Experimental/SwipeableRow/SwipeableFlatList.js] - Removed proptypes
[GENERAL] [ENHANCEMENT] [Libraries/Experimental/SwipeableRow/SwipeableQuickActions.js] - Removed proptypes