Android: Close websocket properly when remote server initiates close #22248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default react-native template has ic_launcher_round icons on the resources but has not been used.
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
dulmandakh
approved these changes
Nov 13, 2018
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 13, 2018
There was a problem hiding this comment.
@dulmandakh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…acebook#22248) Summary: When the remote server closes the websocket, the app doesn't get a 'close' event in Android, There is no issue on iOS. Pull Request resolved: facebook#22248 Differential Revision: D13047556 Pulled By: hramos fbshipit-source-id: c5c56ea8418cfdf734fb51f863b3066856de6512
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the remote server closes the websocket, the app doesn't get a 'close' event in Android, There is no issue on iOS.
Test Plan:
After making the changes, the app behaved similar to iOS. The 'close' event was sent on WebSocket on android as well.
Changelog:
[Android] [Fixed] - Close websocket properly on android when remote server initiates close