lazy configure ReactAndroid gradle tasks #26314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@friederbluemle @gengjiawen please review |
|
Awesome, it's working for me locally! 👍 Thanks @dulmandakh 🎉 |
gengjiawen
reviewed
Sep 4, 2019
|
@friederbluemle please approve it if it worked 😉 |
mdvacca
approved these changes
Sep 4, 2019
facebook-github-bot
approved these changes
Sep 4, 2019
There was a problem hiding this comment.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gengjiawen
approved these changes
Sep 4, 2019
|
@mdvacca any news? |
|
trying one more time... |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 6, 2019
Summary: Gradle wrapper `5.6.2` Supersedes and closes #26227 ## Changelog [Android] [Changed] - Gradle wrapper 5.6.2 Pull Request resolved: #26349 Test Plan: Builds successfully (just like the current `master` branch, **only** after either reverting 4763000 **or** cherry-picking 7f23878 from #26314) Differential Revision: D17224299 Pulled By: mdvacca fbshipit-source-id: cbd1b3d5d686e284fdc8e3f6faaeaa93654b301d
|
@dulmandakh this PR keeps failing with the following error:
I think the change from Line 213 is affecting the build? |
|
@mdvacca - Which task are you running that is failing? |
|
@mdvacca please make sure that you have NDK installed and ANDROID_NDK environment variable points to it. |
|
@mdvacca the :ReactAndroid:buildReactNdkLib task works as expected if NDK is set |
|
@cpojer please merge |
|
I just tested this again, and it (still) works. 👍 |
|
@dulmandakh CI is failing with the same error @mdvacca mentioned above. Could you fix that first? |
facebook-github-bot
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @dulmandakh in 7c8e266. When will my fix make it into a release? | Upcoming Releases |
vovkasm
pushed a commit
to vovkasm/react-native
that referenced
this pull request
Sep 19, 2019
Summary: ReactAndroid Gradle was failing mysteriously with error below, because it was trying to read values from **android** when it wasn't configured completely. ```java extensionSupplier.get()!!.compileSdkVersion must not be null ``` or ```java compileSdkVersion is not specified. ``` It is happening because **buildReactNdkLib** task was created and configured eagerly. So this PR changes some tasks to be configured lazily, and reads values from **android** when ready. Also remove ANDROID_NDK variable check because android gradle plugin doing it automatically. [Android] [Changed] - lazily configure ReactAndroid gradle tasks Pull Request resolved: facebook#26314 Test Plan: ./gradlew ReactAndroid:tasks run without errors, while master throws exception. Differential Revision: D17177945 Pulled By: cpojer fbshipit-source-id: c7a165092157d2059f946da70b801d1a475d4b8c (cherry picked from commit 7c8e266)
ide
pushed a commit
to expo/react-native
that referenced
this pull request
Oct 4, 2019
Summary: ReactAndroid Gradle was failing mysteriously with error below, because it was trying to read values from **android** when it wasn't configured completely. ```java extensionSupplier.get()!!.compileSdkVersion must not be null ``` or ```java compileSdkVersion is not specified. ``` It is happening because **buildReactNdkLib** task was created and configured eagerly. So this PR changes some tasks to be configured lazily, and reads values from **android** when ready. Also remove ANDROID_NDK variable check because android gradle plugin doing it automatically. ## Changelog [Android] [Changed] - lazily configure ReactAndroid gradle tasks Pull Request resolved: facebook#26314 Test Plan: ./gradlew ReactAndroid:tasks run without errors, while master throws exception. Differential Revision: D17177945 Pulled By: cpojer fbshipit-source-id: c7a165092157d2059f946da70b801d1a475d4b8c
ide
pushed a commit
to expo/react-native
that referenced
this pull request
Oct 4, 2019
Summary: ReactAndroid Gradle was failing mysteriously with error below, because it was trying to read values from **android** when it wasn't configured completely. ```java extensionSupplier.get()!!.compileSdkVersion must not be null ``` or ```java compileSdkVersion is not specified. ``` It is happening because **buildReactNdkLib** task was created and configured eagerly. So this PR changes some tasks to be configured lazily, and reads values from **android** when ready. Also remove ANDROID_NDK variable check because android gradle plugin doing it automatically. ## Changelog [Android] [Changed] - lazily configure ReactAndroid gradle tasks Pull Request resolved: facebook#26314 Test Plan: ./gradlew ReactAndroid:tasks run without errors, while master throws exception. Differential Revision: D17177945 Pulled By: cpojer fbshipit-source-id: c7a165092157d2059f946da70b801d1a475d4b8c
ide
pushed a commit
to expo/react-native
that referenced
this pull request
Oct 12, 2019
Summary: ReactAndroid Gradle was failing mysteriously with error below, because it was trying to read values from **android** when it wasn't configured completely. ```java extensionSupplier.get()!!.compileSdkVersion must not be null ``` or ```java compileSdkVersion is not specified. ``` It is happening because **buildReactNdkLib** task was created and configured eagerly. So this PR changes some tasks to be configured lazily, and reads values from **android** when ready. Also remove ANDROID_NDK variable check because android gradle plugin doing it automatically. ## Changelog [Android] [Changed] - lazily configure ReactAndroid gradle tasks Pull Request resolved: facebook#26314 Test Plan: ./gradlew ReactAndroid:tasks run without errors, while master throws exception. Differential Revision: D17177945 Pulled By: cpojer fbshipit-source-id: c7a165092157d2059f946da70b801d1a475d4b8c
dustinyoste
pushed a commit
to dustinyoste/react-native
that referenced
this pull request
Nov 1, 2019
Summary: ReactAndroid Gradle was failing mysteriously with error below, because it was trying to read values from **android** when it wasn't configured completely. ```java extensionSupplier.get()!!.compileSdkVersion must not be null ``` or ```java compileSdkVersion is not specified. ``` It is happening because **buildReactNdkLib** task was created and configured eagerly. So this PR changes some tasks to be configured lazily, and reads values from **android** when ready. Also remove ANDROID_NDK variable check because android gradle plugin doing it automatically. ## Changelog [Android] [Changed] - lazily configure ReactAndroid gradle tasks Pull Request resolved: facebook#26314 Test Plan: ./gradlew ReactAndroid:tasks run without errors, while master throws exception. Differential Revision: D17177945 Pulled By: cpojer fbshipit-source-id: c7a165092157d2059f946da70b801d1a475d4b8c
sjchmiela
pushed a commit
to expo/react-native
that referenced
this pull request
Nov 12, 2019
Summary: ReactAndroid Gradle was failing mysteriously with error below, because it was trying to read values from **android** when it wasn't configured completely. ```java extensionSupplier.get()!!.compileSdkVersion must not be null ``` or ```java compileSdkVersion is not specified. ``` It is happening because **buildReactNdkLib** task was created and configured eagerly. So this PR changes some tasks to be configured lazily, and reads values from **android** when ready. Also remove ANDROID_NDK variable check because android gradle plugin doing it automatically. ## Changelog [Android] [Changed] - lazily configure ReactAndroid gradle tasks Pull Request resolved: facebook#26314 Test Plan: ./gradlew ReactAndroid:tasks run without errors, while master throws exception. Differential Revision: D17177945 Pulled By: cpojer fbshipit-source-id: c7a165092157d2059f946da70b801d1a475d4b8c
sjchmiela
pushed a commit
to expo/react-native
that referenced
this pull request
Nov 13, 2019
Summary: ReactAndroid Gradle was failing mysteriously with error below, because it was trying to read values from **android** when it wasn't configured completely. ```java extensionSupplier.get()!!.compileSdkVersion must not be null ``` or ```java compileSdkVersion is not specified. ``` It is happening because **buildReactNdkLib** task was created and configured eagerly. So this PR changes some tasks to be configured lazily, and reads values from **android** when ready. Also remove ANDROID_NDK variable check because android gradle plugin doing it automatically. ## Changelog [Android] [Changed] - lazily configure ReactAndroid gradle tasks Pull Request resolved: facebook#26314 Test Plan: ./gradlew ReactAndroid:tasks run without errors, while master throws exception. Differential Revision: D17177945 Pulled By: cpojer fbshipit-source-id: c7a165092157d2059f946da70b801d1a475d4b8c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ReactAndroid Gradle was failing mysteriously with error below, because it was trying to read values from android when it wasn't configured completely.
or
It is happening because buildReactNdkLib task was created and configured eagerly. So this PR changes some tasks to be configured lazily, and reads values from android when ready. Also remove ANDROID_NDK variable check because android gradle plugin doing it automatically.
Changelog
[Android] [Changed] - lazily configure ReactAndroid gradle tasks
Test Plan
./gradlew ReactAndroid:tasks run without errors, while master throws exception.