Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .node-version file from repo root and template #36208

Closed
wants to merge 1 commit into from

Commits on Feb 18, 2023

  1. Remove .node-version file from repo root and template

    Summary:
    IMO, there's no value in having `.node-version` files either in the repository or the template.
    
    I don't believe it's standard practice, the support from tooling is patchy (at least `nvm` [ignores it](nvm-sh/nvm#794), and Node is often used without a version manager), and it's unnecessarily restrictive when it is actually enforced. In every other case, it's potentially misleading noise.
    
    Libraries should use `package.json#engines` to specify their Node JS compatibility ranges, as indeed `react-native` [already does](https:/facebook/react-native/blob/1629b9f0a11f42ff12c6dd06a20afb80067e4958/package.json#L10). React Native users may wish to add one to their own projects according to their own setup or team, but we shouldn't confuse the issue by including an arbitrary one in the template.
    
    Changelog:
    [General][Removed] Remove `.node_version` from app template.
    
    Differential Revision: D43421085
    
    fbshipit-source-id: 37558ef3aee6479b40746cccf83beb1577473786
    robhogan authored and facebook-github-bot committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    f114ad0 View commit details
    Browse the repository at this point in the history