Skip to content

Commit

Permalink
Tweaked some test names after @gaearon review comment #9221 (comment)
Browse files Browse the repository at this point in the history
…. Also realized that one of the tests was essentially a direct copy of another, so deleted it.
  • Loading branch information
aickin committed Mar 21, 2017
1 parent 2781c49 commit 091d7fd
Show file tree
Hide file tree
Showing 4 changed files with 131 additions and 153 deletions.
33 changes: 16 additions & 17 deletions scripts/fiber/tests-failing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -48,27 +48,26 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
* renders no HTML events with client render on top of good server markup
* renders a div with text with client render on top of good server markup
* renders a div with text with flanking whitespace with client render on top of good server markup
* renders a div with text with client render on top of good server markup
* renders a div with blank text child with client render on top of good server markup
* renders renders a div with blank text children with server string render
* renders renders a div with blank text children with client render on top of good server markup
* renders a div with whitespace children with server string render
* renders a div with whitespace children with client render on top of good server markup
* renders a div with text child in brackets with client render on top of good server markup
* renders a div with an empty text child with client render on top of good server markup
* renders a div with multiple empty text children with server string render
* renders a div with multiple empty text children with client render on top of good server markup
* renders a div with multiple whitespace children with server string render
* renders a div with multiple whitespace children with client render on top of good server markup
* renders a div with text sibling to a node with server string render
* renders a div with text sibling to a node with client render on top of good server markup
* renders a non-standard element with text with client render on top of good server markup
* renders a custom element with text with client render on top of good server markup
* renders leading blank children with comments when there are multiple children with server string render
* renders leading blank children with comments when there are multiple children with client render on top of good server markup
* renders trailing blank children with comments when there are multiple children with server string render
* renders trailing blank children with comments when there are multiple children with client render on top of good server markup
* renders an element with just one text child without comments with client render on top of good server markup
* renders an element with two text children with comments with server string render
* renders an element with two text children with comments with client render on top of good server markup
* renders a leading blank child with a text sibling with server string render
* renders a leading blank child with a text sibling with client render on top of good server markup
* renders a trailing blank child with a text sibling with server string render
* renders a trailing blank child with a text sibling with client render on top of good server markup
* renders an element with two text children with server string render
* renders an element with two text children with client render on top of good server markup
* renders a number as single child with client render on top of good server markup
* renders zero as single child with client render on top of good server markup
* renders an element with number and text children with comments with server string render
* renders an element with number and text children with comments with client render on top of good server markup
* renders an element with number and text children with server string render
* renders an element with number and text children with client render on top of good server markup
* renders null single child as blank with client render on top of good server markup
* renders false single child as blank with client render on top of good server markup
* renders undefined single child as blank with client render on top of good server markup
Expand Down Expand Up @@ -100,8 +99,8 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
* renders a div with multiple children with client render on top of good server markup
* renders a div with multiple children separated by whitespace with server string render
* renders a div with multiple children separated by whitespace with client render on top of good server markup
* renders a div with a child surrounded by whitespace with server string render
* renders a div with a child surrounded by whitespace with client render on top of good server markup
* renders a div with a single child surrounded by whitespace with server string render
* renders a div with a single child surrounded by whitespace with client render on top of good server markup
* renders >,<, and & as single child with client render on top of good server markup
* renders >,<, and & as multiple children with server string render
* renders >,<, and & as multiple children with client render on top of good server markup
Expand Down
19 changes: 9 additions & 10 deletions scripts/fiber/tests-passing-except-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -49,20 +49,19 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
* renders no HTML events with client render on top of bad server markup
* renders a div with text with client render on top of bad server markup
* renders a div with text with flanking whitespace with client render on top of bad server markup
* renders a div with text with client render on top of bad server markup
* renders a div with blank text child with client render on top of bad server markup
* renders renders a div with blank text children with client render on top of bad server markup
* renders a div with whitespace children with client render on top of bad server markup
* renders a div with text child in brackets with client render on top of bad server markup
* renders a div with an empty text child with client render on top of bad server markup
* renders a div with multiple empty text children with client render on top of bad server markup
* renders a div with multiple whitespace children with client render on top of bad server markup
* renders a div with text sibling to a node with client render on top of bad server markup
* renders a non-standard element with text with client render on top of bad server markup
* renders a custom element with text with client render on top of bad server markup
* renders leading blank children with comments when there are multiple children with client render on top of bad server markup
* renders trailing blank children with comments when there are multiple children with client render on top of bad server markup
* renders an element with just one text child without comments with client render on top of bad server markup
* renders an element with two text children with comments with client render on top of bad server markup
* renders a leading blank child with a text sibling with client render on top of bad server markup
* renders a trailing blank child with a text sibling with client render on top of bad server markup
* renders an element with two text children with client render on top of bad server markup
* renders a number as single child with client render on top of bad server markup
* renders zero as single child with client render on top of bad server markup
* renders an element with number and text children with comments with client render on top of bad server markup
* renders an element with number and text children with client render on top of bad server markup
* renders null single child as blank with client render on top of bad server markup
* renders false single child as blank with client render on top of bad server markup
* renders undefined single child as blank with client render on top of bad server markup
Expand All @@ -89,7 +88,7 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
* renders a div with a child with client render on top of bad server markup
* renders a div with multiple children with client render on top of bad server markup
* renders a div with multiple children separated by whitespace with client render on top of bad server markup
* renders a div with a child surrounded by whitespace with client render on top of bad server markup
* renders a div with a single child surrounded by whitespace with client render on top of bad server markup
* renders >,<, and & as single child with client render on top of bad server markup
* renders >,<, and & as multiple children with client render on top of bad server markup
* throws when rendering a string component with clean client render
Expand Down
24 changes: 11 additions & 13 deletions scripts/fiber/tests-passing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1142,27 +1142,25 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
* renders a div with text with clean client render
* renders a div with text with flanking whitespace with server string render
* renders a div with text with flanking whitespace with clean client render
* renders a div with text with server string render
* renders a div with text with clean client render
* renders a div with blank text child with server string render
* renders a div with blank text child with clean client render
* renders renders a div with blank text children with clean client render
* renders a div with whitespace children with clean client render
* renders a div with text child in brackets with server string render
* renders a div with text child in brackets with clean client render
* renders a div with an empty text child with server string render
* renders a div with an empty text child with clean client render
* renders a div with multiple empty text children with clean client render
* renders a div with multiple whitespace children with clean client render
* renders a div with text sibling to a node with clean client render
* renders a non-standard element with text with server string render
* renders a non-standard element with text with clean client render
* renders a custom element with text with server string render
* renders a custom element with text with clean client render
* renders leading blank children with comments when there are multiple children with clean client render
* renders trailing blank children with comments when there are multiple children with clean client render
* renders an element with just one text child without comments with server string render
* renders an element with just one text child without comments with clean client render
* renders an element with two text children with comments with clean client render
* renders a leading blank child with a text sibling with clean client render
* renders a trailing blank child with a text sibling with clean client render
* renders an element with two text children with clean client render
* renders a number as single child with server string render
* renders a number as single child with clean client render
* renders zero as single child with server string render
* renders zero as single child with clean client render
* renders an element with number and text children with comments with clean client render
* renders an element with number and text children with clean client render
* renders null single child as blank with server string render
* renders null single child as blank with clean client render
* renders false single child as blank with server string render
Expand Down Expand Up @@ -1210,7 +1208,7 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
* renders a div with multiple children with server string render
* renders a div with multiple children with clean client render
* renders a div with multiple children separated by whitespace with clean client render
* renders a div with a child surrounded by whitespace with clean client render
* renders a div with a single child surrounded by whitespace with clean client render
* renders >,<, and & as single child with server string render
* renders >,<, and & as single child with clean client render
* renders >,<, and & as multiple children with clean client render
Expand Down
Loading

0 comments on commit 091d7fd

Please sign in to comment.