Remove initOption

facebook · Apr 11, 2023 · 0d9515b · 0d9515b
1 parent ac43bf6
commit 0d9515b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 20 deletions.
diff --git a/packages/react-dom-bindings/src/client/ReactDOMComponent.js b/packages/react-dom-bindings/src/client/ReactDOMComponent.js
@@ -32,7 +32,7 @@ import {
  updateInput,
  restoreControlledInputState,
 } from './ReactDOMInput';
-import {initOption, validateOptionProps} from './ReactDOMOption';
+import {validateOptionProps} from './ReactDOMOption';
 import {
  validateSelectProps,
  initSelect,
@@ -995,7 +995,6 @@ export function setInitialProperties(
  }
  }
  }
- initOption(domElement, props);
  return;
  }
  case 'dialog': {

diff --git a/packages/react-dom-bindings/src/client/ReactDOMOption.js b/packages/react-dom-bindings/src/client/ReactDOMOption.js
@@ -59,10 +59,3 @@ export function validateOptionProps(element: Element, props: Object) {
  }
  }
 }
-
-export function initOption(element: Element, props: Object) {
- // value="" should make a value attribute (#6219)
- if (props.value != null) {
- element.setAttribute('value', toString(getToStringValue(props.value)));
- }
-}
diff --git a/packages/react-dom/src/__tests__/ReactDOMSelect-test.js b/packages/react-dom/src/__tests__/ReactDOMSelect-test.js
@@ -849,7 +849,7 @@ describe('ReactDOMSelect', () => {
  });
 
  describe('When given a Symbol value', () => {
- it('treats initial Symbol value as an empty string', () => {
+ it('treats initial Symbol value as missing', () => {
  let node;
 
  expect(() => {
@@ -862,10 +862,10 @@ describe('ReactDOMSelect', () => {
  );
  }).toErrorDev('Invalid value for prop `value`');
 
- expect(node.value).toBe('');
+ expect(node.value).toBe('A Symbol!');
  });
 
- it('treats updated Symbol value as an empty string', () => {
+ it('treats updated Symbol value as missing', () => {
  let node;
 
  expect(() => {
@@ -888,7 +888,7 @@ describe('ReactDOMSelect', () => {
  </select>,
  );
 
- expect(node.value).toBe('');
+ expect(node.value).toBe('A Symbol!');
  });
 
  it('treats initial Symbol defaultValue as an empty string', () => {
@@ -904,7 +904,7 @@ describe('ReactDOMSelect', () => {
  );
  }).toErrorDev('Invalid value for prop `value`');
 
- expect(node.value).toBe('');
+ expect(node.value).toBe('A Symbol!');
  });
 
  it('treats updated Symbol defaultValue as an empty string', () => {
@@ -930,12 +930,12 @@ describe('ReactDOMSelect', () => {
  </select>,
  );
 
- expect(node.value).toBe('');
+ expect(node.value).toBe('A Symbol!');
  });
  });
 
  describe('When given a function value', () => {
- it('treats initial function value as an empty string', () => {
+ it('treats initial function value as missing', () => {
  let node;
 
  expect(() => {
@@ -948,7 +948,7 @@ describe('ReactDOMSelect', () => {
  );
  }).toErrorDev('Invalid value for prop `value`');
 
- expect(node.value).toBe('');
+ expect(node.value).toBe('A function!');
  });
 
  it('treats initial function defaultValue as an empty string', () => {
@@ -964,7 +964,7 @@ describe('ReactDOMSelect', () => {
  );
  }).toErrorDev('Invalid value for prop `value`');
 
- expect(node.value).toBe('');
+ expect(node.value).toBe('A function!');
  });
 
  it('treats updated function value as an empty string', () => {
@@ -990,7 +990,7 @@ describe('ReactDOMSelect', () => {
  </select>,
  );
 
- expect(node.value).toBe('');
+ expect(node.value).toBe('A function!');
  });
 
  it('treats updated function defaultValue as an empty string', () => {
@@ -1016,7 +1016,7 @@ describe('ReactDOMSelect', () => {
  </select>,
  );
 
- expect(node.value).toBe('');
+ expect(node.value).toBe('A function!');
  });
  });