fix tests for when float is off (#25839)

Some tests fail when float is off but when singletons are on. This PR makes some adjustments 1. 2 singleton tests assert float semantics so will fail. 2. the float dispatcher was being set on the server even when float was off. while the float calls didn't do anything warnings were still generated. Instead we provide an empty object for the dispatcher if float is off. Longer term the dispatcher should move to formatconfig and just reference the float methods if the flag is on 3. some external fizz runtime tests did not gate against float but should have DiffTrain build for `5dfc485f6957bf941fcd9565e0271aea019d7c9e`
facebook · Dec 7, 2022 · 117fb14 · 117fb14
1 parent 03bb771
commit 117fb14
Show file tree

Hide file tree

Showing 36 changed files with 68 additions and 65 deletions.
diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION
@@ -1 +1 @@
-827cbdbcc694e1aa9f4a8768c8677a1531c77ea3
+5dfc485f6957bf941fcd9565e0271aea019d7c9e
diff --git a/compiled/facebook-www/REVISION_TRANSFORMS b/compiled/facebook-www/REVISION_TRANSFORMS
@@ -1 +1 @@
-827cbdbcc694e1aa9f4a8768c8677a1531c77ea3
+5dfc485f6957bf941fcd9565e0271aea019d7c9e
diff --git a/compiled/facebook-www/React-dev.classic.js b/compiled/facebook-www/React-dev.classic.js
@@ -27,7 +27,7 @@ if (
 }
  "use strict";
 
-var ReactVersion = "18.3.0-www-classic-827cbdbcc-20221207";
+var ReactVersion = "18.3.0-www-classic-5dfc485f6-20221207";
 
 // ATTENTION
 // When adding new symbols to this file,

diff --git a/compiled/facebook-www/React-dev.modern.js b/compiled/facebook-www/React-dev.modern.js
@@ -27,7 +27,7 @@ if (
 }
  "use strict";
 
-var ReactVersion = "18.3.0-www-modern-827cbdbcc-20221207";
+var ReactVersion = "18.3.0-www-modern-5dfc485f6-20221207";
 
 // ATTENTION
 // When adding new symbols to this file,

diff --git a/compiled/facebook-www/React-prod.classic.js b/compiled/facebook-www/React-prod.classic.js
@@ -643,4 +643,4 @@ exports.useSyncExternalStore = function(
  );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-827cbdbcc-20221207";
+exports.version = "18.3.0-www-classic-5dfc485f6-20221207";
diff --git a/compiled/facebook-www/React-prod.modern.js b/compiled/facebook-www/React-prod.modern.js
@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function(
  );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-827cbdbcc-20221207";
+exports.version = "18.3.0-www-modern-5dfc485f6-20221207";
diff --git a/compiled/facebook-www/React-profiling.classic.js b/compiled/facebook-www/React-profiling.classic.js
@@ -654,7 +654,7 @@ exports.useSyncExternalStore = function(
  );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-827cbdbcc-20221207";
+exports.version = "18.3.0-www-classic-5dfc485f6-20221207";
 
  /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/React-profiling.modern.js b/compiled/facebook-www/React-profiling.modern.js
@@ -646,7 +646,7 @@ exports.useSyncExternalStore = function(
  );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-827cbdbcc-20221207";
+exports.version = "18.3.0-www-modern-5dfc485f6-20221207";
 
  /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/ReactART-dev.classic.js b/compiled/facebook-www/ReactART-dev.classic.js
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
  return self;
 }
 
-var ReactVersion = "18.3.0-www-classic-827cbdbcc-20221207";
+var ReactVersion = "18.3.0-www-classic-5dfc485f6-20221207";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;

diff --git a/compiled/facebook-www/ReactART-dev.modern.js b/compiled/facebook-www/ReactART-dev.modern.js
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
  return self;
 }
 
-var ReactVersion = "18.3.0-www-modern-827cbdbcc-20221207";
+var ReactVersion = "18.3.0-www-modern-5dfc485f6-20221207";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;

diff --git a/compiled/facebook-www/ReactART-prod.classic.js b/compiled/facebook-www/ReactART-prod.classic.js
@@ -9782,7 +9782,7 @@ var slice = Array.prototype.slice,
  return null;
  },
  bundleType: 0,
- version: "18.3.0-www-classic-827cbdbcc-20221207",
+ version: "18.3.0-www-classic-5dfc485f6-20221207",
  rendererPackageName: "react-art"
  };
 var internals$jscomp$inline_1336 = {
@@ -9813,7 +9813,7 @@ var internals$jscomp$inline_1336 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-827cbdbcc-20221207"
+ reconcilerVersion: "18.3.0-next-5dfc485f6-20221207"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_1337 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/compiled/facebook-www/ReactART-prod.modern.js b/compiled/facebook-www/ReactART-prod.modern.js
@@ -9449,7 +9449,7 @@ var slice = Array.prototype.slice,
  return null;
  },
  bundleType: 0,
- version: "18.3.0-www-modern-827cbdbcc-20221207",
+ version: "18.3.0-www-modern-5dfc485f6-20221207",
  rendererPackageName: "react-art"
  };
 var internals$jscomp$inline_1327 = {
@@ -9480,7 +9480,7 @@ var internals$jscomp$inline_1327 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-827cbdbcc-20221207"
+ reconcilerVersion: "18.3.0-next-5dfc485f6-20221207"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_1328 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/compiled/facebook-www/ReactDOM-dev.classic.js b/compiled/facebook-www/ReactDOM-dev.classic.js
@@ -42530,7 +42530,7 @@ function createFiberRoot(
  return root;
 }
 
-var ReactVersion = "18.3.0-www-classic-827cbdbcc-20221207";
+var ReactVersion = "18.3.0-www-classic-5dfc485f6-20221207";
 
 function createPortal(
  children,

diff --git a/compiled/facebook-www/ReactDOM-dev.modern.js b/compiled/facebook-www/ReactDOM-dev.modern.js
@@ -42254,7 +42254,7 @@ function createFiberRoot(
  return root;
 }
 
-var ReactVersion = "18.3.0-www-modern-827cbdbcc-20221207";
+var ReactVersion = "18.3.0-www-modern-5dfc485f6-20221207";
 
 function createPortal(
  children,

diff --git a/compiled/facebook-www/ReactDOM-prod.classic.js b/compiled/facebook-www/ReactDOM-prod.classic.js
@@ -15537,7 +15537,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1773 = {
  findFiberByHostInstance: getClosestInstanceFromNode,
  bundleType: 0,
- version: "18.3.0-www-classic-827cbdbcc-20221207",
+ version: "18.3.0-www-classic-5dfc485f6-20221207",
  rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2154 = {
@@ -15567,7 +15567,7 @@ var internals$jscomp$inline_2154 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-827cbdbcc-20221207"
+ reconcilerVersion: "18.3.0-next-5dfc485f6-20221207"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_2155 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15809,4 +15809,4 @@ exports.unstable_renderSubtreeIntoContainer = function(
  );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-827cbdbcc-20221207";
+exports.version = "18.3.0-next-5dfc485f6-20221207";
diff --git a/compiled/facebook-www/ReactDOM-prod.modern.js b/compiled/facebook-www/ReactDOM-prod.modern.js
@@ -15098,7 +15098,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1741 = {
  findFiberByHostInstance: getClosestInstanceFromNode,
  bundleType: 0,
- version: "18.3.0-www-modern-827cbdbcc-20221207",
+ version: "18.3.0-www-modern-5dfc485f6-20221207",
  rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2129 = {
@@ -15129,7 +15129,7 @@ var internals$jscomp$inline_2129 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-827cbdbcc-20221207"
+ reconcilerVersion: "18.3.0-next-5dfc485f6-20221207"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_2130 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15317,4 +15317,4 @@ exports.unstable_flushControlled = function(fn) {
  }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-827cbdbcc-20221207";
+exports.version = "18.3.0-next-5dfc485f6-20221207";
diff --git a/compiled/facebook-www/ReactDOM-profiling.classic.js b/compiled/facebook-www/ReactDOM-profiling.classic.js
@@ -16308,7 +16308,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1847 = {
  findFiberByHostInstance: getClosestInstanceFromNode,
  bundleType: 0,
- version: "18.3.0-www-classic-827cbdbcc-20221207",
+ version: "18.3.0-www-classic-5dfc485f6-20221207",
  rendererPackageName: "react-dom"
 };
 (function(internals) {
@@ -16352,7 +16352,7 @@ var devToolsConfig$jscomp$inline_1847 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-827cbdbcc-20221207"
+ reconcilerVersion: "18.3.0-next-5dfc485f6-20221207"
 });
 assign(Internals, {
  ReactBrowserEventEmitter: {
@@ -16581,7 +16581,7 @@ exports.unstable_renderSubtreeIntoContainer = function(
  );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-827cbdbcc-20221207";
+exports.version = "18.3.0-next-5dfc485f6-20221207";
 
  /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/ReactDOM-profiling.modern.js b/compiled/facebook-www/ReactDOM-profiling.modern.js
@@ -15859,7 +15859,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1815 = {
  findFiberByHostInstance: getClosestInstanceFromNode,
  bundleType: 0,
- version: "18.3.0-www-modern-827cbdbcc-20221207",
+ version: "18.3.0-www-modern-5dfc485f6-20221207",
  rendererPackageName: "react-dom"
 };
 (function(internals) {
@@ -15904,7 +15904,7 @@ var devToolsConfig$jscomp$inline_1815 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-827cbdbcc-20221207"
+ reconcilerVersion: "18.3.0-next-5dfc485f6-20221207"
 });
 exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
 exports.createPortal = function(children, container) {
@@ -16079,7 +16079,7 @@ exports.unstable_flushControlled = function(fn) {
  }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-827cbdbcc-20221207";
+exports.version = "18.3.0-next-5dfc485f6-20221207";
 
  /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/ReactDOMForked-dev.classic.js b/compiled/facebook-www/ReactDOMForked-dev.classic.js
@@ -42530,7 +42530,7 @@ function createFiberRoot(
  return root;
 }
 
-var ReactVersion = "18.3.0-www-classic-827cbdbcc-20221207";
+var ReactVersion = "18.3.0-www-classic-5dfc485f6-20221207";
 
 function createPortal(
  children,

diff --git a/compiled/facebook-www/ReactDOMForked-dev.modern.js b/compiled/facebook-www/ReactDOMForked-dev.modern.js
@@ -42254,7 +42254,7 @@ function createFiberRoot(
  return root;
 }
 
-var ReactVersion = "18.3.0-www-modern-827cbdbcc-20221207";
+var ReactVersion = "18.3.0-www-modern-5dfc485f6-20221207";
 
 function createPortal(
  children,

diff --git a/compiled/facebook-www/ReactDOMForked-prod.classic.js b/compiled/facebook-www/ReactDOMForked-prod.classic.js
@@ -15537,7 +15537,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1773 = {
  findFiberByHostInstance: getClosestInstanceFromNode,
  bundleType: 0,
- version: "18.3.0-www-classic-827cbdbcc-20221207",
+ version: "18.3.0-www-classic-5dfc485f6-20221207",
  rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2154 = {
@@ -15567,7 +15567,7 @@ var internals$jscomp$inline_2154 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-827cbdbcc-20221207"
+ reconcilerVersion: "18.3.0-next-5dfc485f6-20221207"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_2155 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15809,4 +15809,4 @@ exports.unstable_renderSubtreeIntoContainer = function(
  );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-827cbdbcc-20221207";
+exports.version = "18.3.0-next-5dfc485f6-20221207";
diff --git a/compiled/facebook-www/ReactDOMForked-prod.modern.js b/compiled/facebook-www/ReactDOMForked-prod.modern.js
@@ -15098,7 +15098,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1741 = {
  findFiberByHostInstance: getClosestInstanceFromNode,
  bundleType: 0,
- version: "18.3.0-www-modern-827cbdbcc-20221207",
+ version: "18.3.0-www-modern-5dfc485f6-20221207",
  rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2129 = {
@@ -15129,7 +15129,7 @@ var internals$jscomp$inline_2129 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-827cbdbcc-20221207"
+ reconcilerVersion: "18.3.0-next-5dfc485f6-20221207"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_2130 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15317,4 +15317,4 @@ exports.unstable_flushControlled = function(fn) {
  }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-827cbdbcc-20221207";
+exports.version = "18.3.0-next-5dfc485f6-20221207";
diff --git a/compiled/facebook-www/ReactDOMForked-profiling.classic.js b/compiled/facebook-www/ReactDOMForked-profiling.classic.js
@@ -16308,7 +16308,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1847 = {
  findFiberByHostInstance: getClosestInstanceFromNode,
  bundleType: 0,
- version: "18.3.0-www-classic-827cbdbcc-20221207",
+ version: "18.3.0-www-classic-5dfc485f6-20221207",
  rendererPackageName: "react-dom"
 };
 (function(internals) {
@@ -16352,7 +16352,7 @@ var devToolsConfig$jscomp$inline_1847 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-827cbdbcc-20221207"
+ reconcilerVersion: "18.3.0-next-5dfc485f6-20221207"
 });
 assign(Internals, {
  ReactBrowserEventEmitter: {
@@ -16581,7 +16581,7 @@ exports.unstable_renderSubtreeIntoContainer = function(
  );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-827cbdbcc-20221207";
+exports.version = "18.3.0-next-5dfc485f6-20221207";
 
  /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/ReactDOMForked-profiling.modern.js b/compiled/facebook-www/ReactDOMForked-profiling.modern.js
@@ -15859,7 +15859,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1815 = {
  findFiberByHostInstance: getClosestInstanceFromNode,
  bundleType: 0,
- version: "18.3.0-www-modern-827cbdbcc-20221207",
+ version: "18.3.0-www-modern-5dfc485f6-20221207",
  rendererPackageName: "react-dom"
 };
 (function(internals) {
@@ -15904,7 +15904,7 @@ var devToolsConfig$jscomp$inline_1815 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-827cbdbcc-20221207"
+ reconcilerVersion: "18.3.0-next-5dfc485f6-20221207"
 });
 exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
 exports.createPortal = function(children, container) {
@@ -16079,7 +16079,7 @@ exports.unstable_flushControlled = function(fn) {
  }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-827cbdbcc-20221207";
+exports.version = "18.3.0-next-5dfc485f6-20221207";
 
  /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/ReactDOMServer-dev.classic.js b/compiled/facebook-www/ReactDOMServer-dev.classic.js
@@ -18,7 +18,7 @@ if (__DEV__) {
 
 var React = require("react");
 
-var ReactVersion = "18.3.0-www-classic-827cbdbcc-20221207";
+var ReactVersion = "18.3.0-www-classic-5dfc485f6-20221207";
 
 // This refers to a WWW module.
 var warningWWW = require("warning");
@@ -2795,7 +2795,7 @@ function setCurrentlyRenderingBoundaryResourcesTarget(
 ) {
  resources.boundaryResources = boundaryResources;
 }
-var ReactDOMServerDispatcher = {
+var ReactDOMServerFloatDispatcher = {
  preload: preload,
  preinit: preinit
 };
@@ -3616,6 +3616,7 @@ var ReactDOMSharedInternals =
  ReactDOM.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;
 
 var ReactDOMCurrentDispatcher = ReactDOMSharedInternals.Dispatcher;
+var ReactDOMServerDispatcher = ReactDOMServerFloatDispatcher;
 function prepareToRender(resources) {
  prepareToRenderResources(resources);
  var previousHostDispatcher = ReactDOMCurrentDispatcher.current;

diff --git a/compiled/facebook-www/ReactDOMServer-dev.modern.js b/compiled/facebook-www/ReactDOMServer-dev.modern.js
@@ -18,7 +18,7 @@ if (__DEV__) {
 
 var React = require("react");
 
-var ReactVersion = "18.3.0-www-modern-827cbdbcc-20221207";
+var ReactVersion = "18.3.0-www-modern-5dfc485f6-20221207";
 
 // This refers to a WWW module.
 var warningWWW = require("warning");
@@ -2799,7 +2799,7 @@ function setCurrentlyRenderingBoundaryResourcesTarget(
 ) {
  resources.boundaryResources = boundaryResources;
 }
-var ReactDOMServerDispatcher = {
+var ReactDOMServerFloatDispatcher = {
  preload: preload,
  preinit: preinit
 };
@@ -3620,6 +3620,7 @@ var ReactDOMSharedInternals =
  ReactDOM.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;
 
 var ReactDOMCurrentDispatcher = ReactDOMSharedInternals.Dispatcher;
+var ReactDOMServerDispatcher = ReactDOMServerFloatDispatcher;
 function prepareToRender(resources) {
  prepareToRenderResources(resources);
  var previousHostDispatcher = ReactDOMCurrentDispatcher.current;