-
Notifications
You must be signed in to change notification settings - Fork 46.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Fizz][Static] when aborting a prerender halt unfinished boundaries i…
…nstead of erroring Halt semantics in Fizz are essentially the same as Postpone. Boundaries will be client rendered but no error will bubble up on the client. In this implementation we literally use the Postpone mechanic for implementing this. The key different between halting and postponing is in the triggering API. Halts happen when you abort a prerender whereas Postpones happened when you call React.unstable_postpone within a render or if you Abort with a postpone. This latter case is an overlap where we would need ot decide which semantics to choose however thankfully aborting with a postpone and halting are equivalent so even when the halt flag is on we can implement this with an arbitrary hierarchy. Note that with halting we still call onError and onPostpone so if you abort a prerender with an error you will see observe the error through this event handler but the client won't recover from an error in the browser.
- Loading branch information
Showing
2 changed files
with
158 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters