Remove initOption special case (#26595)

This traces back to #6449 and then another before that. I think that back then we favored the property over the attribute, and setting the property wouldn't be enough. However, the default path for these are now using attributes if we don't special case it. So we don't need it. The only difference is that we currently have a divergence for symbol/function behavior between controlled values that use the getToStringValue helpers which treat them as empty string, where as everywhere else they're treated as null/missing. Since this comes with a warning and is a weird error case, it's probably fine to change. DiffTrain build for commit 343a45f.
facebook · Apr 11, 2023 · 32f13ee · 32f13ee
1 parent 06b60a9
commit 32f13ee
Show file tree

Hide file tree

Showing 13 changed files with 19 additions and 19 deletions.
diff --git a/...ook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js b/...ook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
@@ -23752,7 +23752,7 @@ function createFiberRoot(
  return root;
 }
 
-var ReactVersion = "18.3.0-next-58742c21b-20230411";
+var ReactVersion = "18.3.0-next-343a45ffa-20230411";
 
 // Might add PROFILE later.
 

diff --git a/...ok-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js b/...ok-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
@@ -8610,7 +8610,7 @@ var devToolsConfig$jscomp$inline_1021 = {
  throw Error("TestRenderer does not support findFiberByHostInstance()");
  },
  bundleType: 0,
- version: "18.3.0-next-58742c21b-20230411",
+ version: "18.3.0-next-343a45ffa-20230411",
  rendererPackageName: "react-test-renderer"
 };
 var internals$jscomp$inline_1204 = {
@@ -8641,7 +8641,7 @@ var internals$jscomp$inline_1204 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-58742c21b-20230411"
+ reconcilerVersion: "18.3.0-next-343a45ffa-20230411"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_1205 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/...source/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js b/...source/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
@@ -9036,7 +9036,7 @@ var devToolsConfig$jscomp$inline_1063 = {
  throw Error("TestRenderer does not support findFiberByHostInstance()");
  },
  bundleType: 0,
- version: "18.3.0-next-58742c21b-20230411",
+ version: "18.3.0-next-343a45ffa-20230411",
  rendererPackageName: "react-test-renderer"
 };
 var internals$jscomp$inline_1245 = {
@@ -9067,7 +9067,7 @@ var internals$jscomp$inline_1245 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-58742c21b-20230411"
+ reconcilerVersion: "18.3.0-next-343a45ffa-20230411"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_1246 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js
@@ -27,7 +27,7 @@ if (
 }
  "use strict";
 
-var ReactVersion = "18.3.0-next-58742c21b-20230411";
+var ReactVersion = "18.3.0-next-343a45ffa-20230411";
 
 // ATTENTION
 // When adding new symbols to this file,

diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js
@@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
  );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-next-58742c21b-20230411";
+exports.version = "18.3.0-next-343a45ffa-20230411";
diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js
@@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
  );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-next-58742c21b-20230411";
+exports.version = "18.3.0-next-343a45ffa-20230411";
 
  /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION
@@ -1 +1 @@
-58742c21b8c3237e8b66c7df4e200504846a01ae
+343a45ffa48065e60699bbe68f82d7b62fa02840
diff --git a/...rce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js b/...rce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js
@@ -27059,7 +27059,7 @@ function createFiberRoot(
  return root;
 }
 
-var ReactVersion = "18.3.0-next-58742c21b-20230411";
+var ReactVersion = "18.3.0-next-343a45ffa-20230411";
 
 function createPortal$1(
  children,

diff --git a/...ce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js b/...ce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js
@@ -9479,7 +9479,7 @@ var roots = new Map(),
  devToolsConfig$jscomp$inline_1045 = {
  findFiberByHostInstance: getInstanceFromNode,
  bundleType: 0,
- version: "18.3.0-next-58742c21b-20230411",
+ version: "18.3.0-next-343a45ffa-20230411",
  rendererPackageName: "react-native-renderer",
  rendererConfig: {
  getInspectorDataForViewTag: function () {
@@ -9521,7 +9521,7 @@ var internals$jscomp$inline_1274 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-58742c21b-20230411"
+ reconcilerVersion: "18.3.0-next-343a45ffa-20230411"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_1275 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/...lat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js b/...lat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js
@@ -10188,7 +10188,7 @@ var roots = new Map(),
  devToolsConfig$jscomp$inline_1123 = {
  findFiberByHostInstance: getInstanceFromNode,
  bundleType: 0,
- version: "18.3.0-next-58742c21b-20230411",
+ version: "18.3.0-next-343a45ffa-20230411",
  rendererPackageName: "react-native-renderer",
  rendererConfig: {
  getInspectorDataForViewTag: function () {
@@ -10243,7 +10243,7 @@ var roots = new Map(),
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-58742c21b-20230411"
+ reconcilerVersion: "18.3.0-next-343a45ffa-20230411"
 });
 exports.createPortal = function (children, containerTag) {
  return createPortal$1(

diff --git a/...t/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js b/...t/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js
@@ -27572,7 +27572,7 @@ function createFiberRoot(
  return root;
 }
 
-var ReactVersion = "18.3.0-next-58742c21b-20230411";
+var ReactVersion = "18.3.0-next-343a45ffa-20230411";
 
 function createPortal$1(
  children,

diff --git a/.../js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js b/.../js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js
@@ -9738,7 +9738,7 @@ var roots = new Map(),
  devToolsConfig$jscomp$inline_1100 = {
  findFiberByHostInstance: getInstanceFromTag,
  bundleType: 0,
- version: "18.3.0-next-58742c21b-20230411",
+ version: "18.3.0-next-343a45ffa-20230411",
  rendererPackageName: "react-native-renderer",
  rendererConfig: {
  getInspectorDataForViewTag: function () {
@@ -9780,7 +9780,7 @@ var internals$jscomp$inline_1343 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-58742c21b-20230411"
+ reconcilerVersion: "18.3.0-next-343a45ffa-20230411"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_1344 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/...eact-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js b/...eact-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js
@@ -10447,7 +10447,7 @@ var roots = new Map(),
  devToolsConfig$jscomp$inline_1178 = {
  findFiberByHostInstance: getInstanceFromTag,
  bundleType: 0,
- version: "18.3.0-next-58742c21b-20230411",
+ version: "18.3.0-next-343a45ffa-20230411",
  rendererPackageName: "react-native-renderer",
  rendererConfig: {
  getInspectorDataForViewTag: function () {
@@ -10502,7 +10502,7 @@ var roots = new Map(),
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-58742c21b-20230411"
+ reconcilerVersion: "18.3.0-next-343a45ffa-20230411"
 });
 exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
  computeComponentStackForErrorReporting: function (reactTag) {