Fix gates for real this time

facebook · Feb 9, 2024 · 5405fae · 5405fae
1 parent c1b9f9c
commit 5405fae
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactErrorBoundaries-test.internal.js b/packages/react-dom/src/__tests__/ReactErrorBoundaries-test.internal.js
@@ -882,8 +882,20 @@ describe('ReactErrorBoundaries', () => {
  expect(container.firstChild.textContent).toBe('Caught an error: Hello.');
  });
 
- // @gate !(disableModulePatternComponents && disableLegacyContext)
- it('renders an error state if module-style context provider throws in componentWillMount', () => {
+ // @gate !disableModulePatternComponents
+ // @gate !disableLegacyContext || !__DEV__
+ it('renders an error state if module-style context provider throws in componentWillMount', async () => {
+ console.log(
+ gate(flags => {
+ return {
+ disableModulePatternComponents: flags.disableModulePatternComponents,
+ disableLegacyContext: flags.disableLegacyContext,
+ val: !(
+ flags.disableModulePatternComponents && flags.disableLegacyContext
+ ),
+ };
+ }),
+ );
  function BrokenComponentWillMountWithContext() {
  return {
  getChildContext() {

diff --git a/packages/react-dom/src/__tests__/ReactLegacyErrorBoundaries-test.internal.js b/packages/react-dom/src/__tests__/ReactLegacyErrorBoundaries-test.internal.js
@@ -824,7 +824,8 @@ describe('ReactLegacyErrorBoundaries', () => {
  );
  expect(container.firstChild.textContent).toBe('Caught an error: Hello.');
  });
- // @gate !disableModulePatternComponents && !disableLegacyContext
+ // @gate !disableModulePatternComponents
+ // @gate !disableLegacyContext || !__DEV__
  it('renders an error state if module-style context provider throws in componentWillMount', () => {
  function BrokenComponentWillMountWithContext() {
  return {

diff --git a/packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js b/packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js
@@ -1756,7 +1756,8 @@ describe('ReactIncrementalErrorHandling', () => {
  );
  });
 
- // @gate !(disableModulePatternComponents && disableLegacyContext)
+ // @gate !disableModulePatternComponents
+ // @gate !disableLegacyContext || !__DEV__
  it('handles error thrown inside getDerivedStateFromProps of a module-style context provider', async () => {
  function Provider() {
  return {