Revert "should improve console output"

This breaks the FB bundles. This reverts commit 65f11ee.
facebook · Mar 10, 2017 · b34e7cf · b34e7cf
1 parent 7f6ecb1
commit b34e7cf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 17 deletions.
diff --git a/scripts/rollup/build.js b/scripts/rollup/build.js
@@ -17,7 +17,6 @@ const {
  replaceInternalModules,
  getFbjsModuleAliases,
  replaceFbjsModuleAliases,
- getExternalModuleList,
 } = require('./modules');
 const {
  bundles,
@@ -205,7 +204,9 @@ function createBundle({babelOpts, entry, fbEntry, config, paths, name, hasteName
  return rollup({
  entry: bundleType === bundleTypes.FB ? fbEntry : entry,
  plugins: getPlugins(entry, babelOpts, paths, filename, bundleType),
- external: getExternalModuleList(),
+ external: [
+ 'react',
+ ],
  }).then(({write}) => write(
  updateBundleConfig(config, filename, format, bundleType, hasteName)
  )).catch(console.error);

diff --git a/scripts/rollup/modules.js b/scripts/rollup/modules.js
@@ -150,26 +150,11 @@ function replaceFbjsModuleAliases(bundleType) {
  }
 }
 
-function getExternalModuleList() {
- // this is to stop Rollup spamming the console with warnings
- return [
- 'react',
- 'warning',
- 'emptyFunction',
- 'emptyObject',
- 'react/lib/ReactCurrentOwner',
- 'react/lib/checkPropTypes',
- 'react/lib/ReactDebugCurrentFrame',
- 'react/lib/ReactComponentTreeHook',
- ];
-}
-
 module.exports = {
  createModuleMap,
  getExternalModules,
  replaceInternalModules,
  getInternalModules,
  getFbjsModuleAliases,
  replaceFbjsModuleAliases,
- getExternalModuleList,
 };