[DevTools] Using array destructuring without assigning first variable…

… does not error
facebook · Aug 18, 2021 · f923e44 · f923e44
1 parent f1db9c3
commit f923e44
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/...t-devtools-extensions/src/__tests__/__source__/__untransformed__/ComponentWithUseState.js b/...t-devtools-extensions/src/__tests__/__source__/__untransformed__/ComponentWithUseState.js
@@ -14,7 +14,8 @@ function Component(props) {
  const [foo] = useState(true);
  const bar = useState(true);
  const [baz] = React.useState(true);
+ const [, forceUpdate] = useState();
  return `${foo}-${bar}-${baz}`;
 }
 
-module.exports = {Component};
+module.exports = {Component};
diff --git a/packages/react-devtools-extensions/src/__tests__/parseHookNames-test.js b/packages/react-devtools-extensions/src/__tests__/parseHookNames-test.js
@@ -95,7 +95,7 @@ describe('parseHookNames', () => {
  const Component = require('./__source__/__untransformed__/ComponentWithUseState')
  .Component;
  const hookNames = await getHookNamesForComponent(Component);
- expectHookNamesToEqual(hookNames, ['foo', 'bar', 'baz']);
+ expectHookNamesToEqual(hookNames, ['foo', 'bar', 'baz', null]);
  });
 
  it('should parse names for useReducer()', async () => {

diff --git a/packages/react-devtools-extensions/src/astUtils.js b/packages/react-devtools-extensions/src/astUtils.js
@@ -271,7 +271,7 @@ function getHookVariableName(
  const nodeType = hook.node.id.type;
  switch (nodeType) {
  case AST_NODE_TYPES.ARRAY_PATTERN:
- return !isCustomHook ? hook.node.id.elements[0].name : null;
+ return !isCustomHook ? hook.node.id.elements[0]?.name ?? null : null;
 
  case AST_NODE_TYPES.IDENTIFIER:
  return hook.node.id.name;