-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react-art
to use new prop-types
package
#10625
Milestone
Comments
Isn't this only relevant for old code in |
(Longer term we should move source of truth back into |
Fixed by #10629. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
Will stop
react-art
from throwing warnings when used with recent React. I haven't tested this manually, but it seems like it will throw because it's using the old style of gettingPropTypes
from React directly.https:/reactjs/react-art/blob/master/src/Wedge.art.js#L28
Also the package is not listing
prop-types
as a dependency -https:/reactjs/react-art/blob/master/package.json
and
https:/facebook/react/blob/master/packages/react-art/package.json
What is the current behavior?
It probably throws a warning, or at least models out-of-date syntax which won't work once we deprecate
React.PropTypes
.If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/ebsrpraL/).
TODO
What is the expected behavior?
Uses
prop-types
package, as shown in the docs.Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React 16.0 beta/RC
The text was updated successfully, but these errors were encountered: