Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Thinking in React example to filter products in FilterableProductTable component #10808

Closed
danielsbird opened this issue Sep 25, 2017 · 1 comment

Comments

@danielsbird
Copy link

In step 4 of the Thinking in React example, the ProductTable component filters and displays an array of products based on user input.

I am unsure why the code for filtering the products is in the ProductTable component and not the FilterableProductTable component. The same question was previously raised in issue #8035.

I think having FilterableProductTable be responsible for filtering the products would improve the example for two reasons:

  • Allow ProductTable to be used outside of FilterableProductTable
  • Better separate the concerns of filtering the products from displaying the products

I updated the example and I'm happy to submit a PR if this is something that should be changed.

@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

Thank you for filing this issue! 😄

The documentation and source code for reactjs.org now lives in a different repository: reactjs/reactjs.org. (For more info on why we made this move, see issue #11075.)

Please open a new issue in that repository. Sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants