Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: DevTools search filtering removes a space #18518

Closed
gaearon opened this issue Apr 7, 2020 · 1 comment · Fixed by #18527
Closed

Bug: DevTools search filtering removes a space #18518

gaearon opened this issue Apr 7, 2020 · 1 comment · Fixed by #18527
Assignees
@bvaughn
Labels
Component: Developer Tools Type: Bug

Comments

@gaearon
Copy link
Collaborator

gaearon commented Apr 7, 2020

Compare two screenshots closely. The space after "from" disappears when the next word is selected.
Screenshot 2020-04-07 at 13 26 40

Screenshot 2020-04-07 at 13 26 35
@gaearon gaearon added Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Component: Developer Tools Type: Bug and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Apr 7, 2020
@bvaughn
Copy link
Contributor

bvaughn commented Apr 7, 2020 •
edited
Loading

Oops. Yeah this looks like a CSS bug.

Each row in the tree is display: inline-flex. This means that <mark>{text}</mark> <span>{text}</span> gets smushed together in a way we don't want. Need to think about this for a minute.

@bvaughn bvaughn self-assigned this Apr 7, 2020
@bvaughn bvaughn mentioned this issue Apr 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvaughn bvaughn

Labels
Component: Developer Tools Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix whitespace problem wiht DevTools Components search bvaughn/react
2 participants
@bvaughn @gaearon