Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Updates to keyed lists break FLIP animations when they occur mid-animation #19406

Closed
dead-claudia opened this issue Jul 19, 2020 · 8 comments
Labels
Resolution: Stale Automatically closed due to inactivity Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@dead-claudia
Copy link

dead-claudia commented Jul 19, 2020

React version: 16.13.1

Steps To Reproduce

  1. Open code example below
  2. Observe animation

Link to code example:

Flems

The current behavior

Animations are choppy

The expected behavior

Animations are smooth like in this example


Context: this bug is far from unique to React: https://twitter.com/isiahmeadows1/status/1284726730574315522

Edit: Also relevant: https:/whatwg/html/issues/5742

@rickhanlonii
Copy link
Member

Hey @isiahmeadows, thanks for filing this issue!

Can you reduce this to a specific React bug? As is, the complaint seems to be that the code just doesn't work as expected. That can happen for a number of reasons that are not bugs in React, so what's the specific React bug we should investigate?

@dead-claudia
Copy link
Author

dead-claudia commented Jul 19, 2020

@rickhanlonii The specific issue is that React applies a keyed diff in such a way that it results in the choppy animations. The only functional difference between the React snippet and the vanilla snippet linked in the "expected behavior" section is the render function. They're otherwise doing the same exact thing to the DOM, and I've verified this through DOM inspection. I've also narrowed it down to appendChild vs insertBefore, as referenced in the linked spec bug.

It's not a bug in React itself, but a browser quirk that React needs to work around.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Dec 25, 2020
@dead-claudia
Copy link
Author

dead-claudia commented Feb 14, 2021

Bumping to not stale, as I haven't received a response or seen any action taken.

@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label Feb 14, 2021
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Apr 10, 2024
@dead-claudia
Copy link
Author

bump

@github-actions github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Apr 12, 2024
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Jul 13, 2024
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Stale Automatically closed due to inactivity Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Development

No branches or pull requests

3 participants
@rickhanlonii @dead-claudia and others