Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Named hooks transient errors #21818

Closed
bvaughn opened this issue Jul 7, 2021 · 2 comments
Closed

[DevTools] Named hooks transient errors #21818

bvaughn opened this issue Jul 7, 2021 · 2 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Jul 7, 2021

Sometimes named hooks inspection will seemingly fail the first time then work the second time. (e.g. using a DEV build of Facebook.com, the <CometTheme> component currently does this).

I think this might indicate a timeout during inspection? (So the retry is fast because everything is cached.)

@bvaughn bvaughn added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Jul 7, 2021
@bvaughn bvaughn self-assigned this Jul 7, 2021
@bvaughn bvaughn added Component: Developer Tools Type: Bug and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Jul 7, 2021
@bvaughn
Copy link
Contributor Author

bvaughn commented Jul 7, 2021

<CometPressable> is another example that (silently) fails to parse any names.

Edit I believe this is because the selected component type is forwardRef rather than a function component.

@bvaughn
Copy link
Contributor Author

bvaughn commented Jul 8, 2021

I think this was actually because the hooks objects get recreated between inspections. Switch to keying them by stable fileName+lineNumber+columnNumber string instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant