Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First 15.6RC bug - CRA throws Can't resolve 'create-react-class/factory' with 15.6.0-rc.1 #9830

Closed
flarnie opened this issue Jun 1, 2017 · 0 comments
Closed

First 15.6RC bug - CRA throws Can't resolve 'create-react-class/factory' with 15.6.0-rc.1 #9830

flarnie opened this issue Jun 1, 2017 · 0 comments
Assignees
@flarnie
Milestone
15.6

Comments

@flarnie
Copy link
Contributor

flarnie commented Jun 1, 2017

Looks like something about the 'create-react-class' removal was not correctly cherry-picked into 15.6.

Steps to reproduce:

  1. create a new CRA project
  2. update the version of React in package.json to 15.6.0-rc.1
  3. run yarn build

You'll get this error:

Module not found: Error: Can't resolve 'create-react-class/factory' in '/Users/flarnie/Code/react_test_projects/click_counter_two/node_modules/react/lib'
@flarnie flarnie added this to the 15.6 milestone Jun 1, 2017
@flarnie flarnie self-assigned this Jun 1, 2017
@flarnie flarnie mentioned this issue Jun 1, 2017
Closed
49 tasks
flarnie added a commit to flarnie/react that referenced this issue Jun 4, 2017
@flarnie
Add 'create-react-class' to react dependencies for build
4e8da5d 
**what is the change?:**
We needed this dependency in the package.json

**why make this change?:**
Even though `create-react-class` was added as a dependency to the
`package.json` in https:/facebook/react/pull/9399/files we
didn't completely cherry-pick this change onto 15.6 from master in facebook@b48b259

This fixes that omission.
Following this fix we will review PR 9399 and make sure nothing else was
missed.

**test plan:**
`yarn build` and inspect the `builds/packages/react/package.json`, see
that `create-react-class` is included.

**issue:**
facebook#9830
@flarnie flarnie mentioned this issue Jun 4, 2017
Merged
flarnie added a commit that referenced this issue Jun 5, 2017
@flarnie
Add 'create-react-class' to react dependencies for build (#9847)
e5b3554 
**what is the change?:**
We needed this dependency in the package.json

**why make this change?:**
Even though `create-react-class` was added as a dependency to the
`package.json` in https:/facebook/react/pull/9399/files we
didn't completely cherry-pick this change onto 15.6 from master in b48b259

This fixes that omission.
Following this fix we will review PR 9399 and make sure nothing else was
missed.

**test plan:**
`yarn build` and inspect the `builds/packages/react/package.json`, see
that `create-react-class` is included.

**issue:**
#9830
@flarnie flarnie closed this as completed Jun 6, 2017
flarnie added a commit to flarnie/react that referenced this issue Jun 7, 2017
@flarnie
Add 'create-react-class' to react dependencies for build (facebook#9847)
5a43ed7 
**what is the change?:**
We needed this dependency in the package.json

**why make this change?:**
Even though `create-react-class` was added as a dependency to the
`package.json` in https:/facebook/react/pull/9399/files we
didn't completely cherry-pick this change onto 15.6 from master in facebook@b48b259

This fixes that omission.
Following this fix we will review PR 9399 and make sure nothing else was
missed.

**test plan:**
`yarn build` and inspect the `builds/packages/react/package.json`, see
that `create-react-class` is included.

**issue:**
facebook#9830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flarnie flarnie

Labels
None yet
Projects
None yet
Milestone
15.6
Development

No branches or pull requests
1 participant
@flarnie