Remove PooledClass from isomorphic build #10227
Conversation
scripts/rollup/results.json
Outdated
| "size": 27099, | ||
| "gzip": 7215 | ||
| "size": 24229, | ||
| "gzip": 6612 |
There was a problem hiding this comment.
whoa. why is FB_PROD so much larger than NODE_PROD/UMD_PROD? Legacy files that are being consumed internally yet?
There was a problem hiding this comment.
No, it's just not minified. We might minify it eventually but for now it doesn't seem necessary (it goes through our pipeline anyway), and it's easier to see what happens during the sync.
| @@ -164,7 +353,7 @@ function mapChildren(children, func, context) { | |||
| return result; | |||
| } | |||
|
|
|||
| function forEachSingleChildDummy(traverseContext, child, name) { | |||
There was a problem hiding this comment.
We're already importing the emptyFunction library in ReactChildren, could use just use emptyFunction.thatReturnsNull and get rid of this?
| * @param {string} key to be escaped. | ||
| * @return {string} the escaped key. | ||
| */ | ||
| function escape(key: string): string { |
There was a problem hiding this comment.
Hey,
Why you added types in flow style if this file have't flow comment?
There was a problem hiding this comment.
Probably accidentally or by copy paste. Want to send a PR to Flow-ify it?
There was a problem hiding this comment.
yep! I can delete useless flow typechecking or add comment flow. If I add flow comment maybe I can try to update types for all file? If you want this.
This inlines
traverseAllChildrenlogic intoReactChildrensince it’s now the only consumer. Then I changeforEachandmapto use the same bookkeeping fields. This lets me unroll thePooledClassabstraction into a single specific implementation, and thus remove it from the isomorphic build.See individual commits.