Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String ref warning shows name of ref #12164

Merged

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Feb 6, 2018

Follow-up for PR #12161

It occurred to me that the error message could be a bit more helpful if we showed the ref name.

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bvaughn bvaughn merged commit 578c82d into facebook:master Feb 6, 2018
@bvaughn bvaughn deleted the improve-strict-mode-string-ref-warning branch February 6, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants