Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfork invariant and instead use it from reactProdInvariant #12585

Merged
merged 1 commit into from
Apr 9, 2018

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Apr 9, 2018

Follow-up to #12539. After chatting with @sophiebits we decided it would be clearer if we just used invariant in both places.

Pros:

Cons:

  • Slightly larger bundles. (A few dozen bytes.)
  • In www's invariant implementation, framesToProp might need to account for React errors specifically (and be 2). Or maybe it doesn't matter since we get the exact message through the decoder anyway.

Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool cool cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants