Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-is] add back proper AsyncMode symbol, for back compat #13959

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Oct 24, 2018

I didn't add tests for isAsyncMode because #13732 didn't preserve any - happy to add them if needed.

@sizebot
Copy link

sizebot commented Oct 24, 2018

Details of bundled changes.

Comparing: 275e76e...fa814c2

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@ljharb
Copy link
Contributor Author

ljharb commented Oct 25, 2018

I have confirmed that these changes cause my enzyme tests in react 16.3 to pass.

@gaearon
Copy link
Collaborator

gaearon commented Oct 31, 2018

Seems okay. We shouldn't have exposed this without the prefix but since we did...

@gaearon gaearon merged commit cdbfa6b into facebook:master Oct 31, 2018
@ljharb ljharb deleted the react-is-async-mode branch October 31, 2018 19:23
ljharb added a commit to enzymejs/enzyme that referenced this pull request Nov 7, 2018
 - Fixes a breaking change wrt `AsyncMode`; reverts 7a36b5a.

See facebook/react#13959
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants