Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: warn when returning different hooks on subsequent renders #14585

Merged
merged 41 commits into from
Jan 22, 2019
Merged

RFC: warn when returning different hooks on subsequent renders #14585

merged 41 commits into from
Jan 22, 2019

Commits on Jan 14, 2019

  1. warn when returning different hooks on next render 

    like it says. adds a field to Hook to track effect 'type', and compares when cloning subsequently.
    Sunil Pai committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    4d8a8cf View commit details
    Browse the repository at this point in the history

  2. lint

    Sunil Pai committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    0daee73 View commit details
    Browse the repository at this point in the history

  3. review changes 

    - numbered enum for hook types
- s/hookType/_debugType
- better dce
    Sunil Pai committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    623fb58 View commit details
    Browse the repository at this point in the history

  4. cleaner detection location

    Sunil Pai committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    1204a0c View commit details
    Browse the repository at this point in the history

  5. redundant comments

    Sunil Pai committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    d597fcd View commit details
    Browse the repository at this point in the history

  6. different EffectHook / LayoutEffectHook

    Sunil Pai committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    1c7314f View commit details
    Browse the repository at this point in the history

  7. prettier

    Sunil Pai committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    5221e91 View commit details
    Browse the repository at this point in the history

  8. top level currentHookType

    Sunil Pai committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    bcbce28 View commit details
    Browse the repository at this point in the history

  9. nulling currentHookType 

    need to verify dce still works
    Sunil Pai committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    a604ea1 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. small enhancements

    Sunil Pai committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    8b22c87 View commit details
    Browse the repository at this point in the history

  2. hook order checks for useContext/useImperative

    Sunil Pai committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    95aa003 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. Merge branch 'master' into wrong-hook-order

    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    cbf4068 View commit details
    Browse the repository at this point in the history

  2. prettier

    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    4676b6b View commit details
    Browse the repository at this point in the history

  3. stray whitespace

    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    5a94b54 View commit details
    Browse the repository at this point in the history

  4. move some bits around

    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    aca87cd View commit details
    Browse the repository at this point in the history

  5. better errors

    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    428a3eb View commit details
    Browse the repository at this point in the history

  6. pass tests

    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    6cd966c View commit details
    Browse the repository at this point in the history

  7. lint, flow

    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    13debbb View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/master' into wrong-hook-order

    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    65ebacb View commit details
    Browse the repository at this point in the history

  9. show a before - after diff

    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    9bd7051 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'upstream/master' into wrong-hook-order

    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    0eea976 View commit details
    Browse the repository at this point in the history

  11. an error stack in the warning

    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    f09966d View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2019

  1. lose currentHookMatches, fix a test

    Sunil Pai committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    e366069 View commit details
    Browse the repository at this point in the history

  2. tidy

    Sunil Pai committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    d8c4236 View commit details
    Browse the repository at this point in the history

  3. clear the mismatch only in dev

    Sunil Pai committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    4801b12 View commit details
    Browse the repository at this point in the history

  4. pass flow

    Sunil Pai committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    c77e448 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2019

  1. side by side diff

    Sunil Pai committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    b6fb3ca View commit details
    Browse the repository at this point in the history

  2. tweak warning

    Sunil Pai committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    055ebf6 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into wrong-hook-order

    Sunil Pai committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    c7a872b View commit details
    Browse the repository at this point in the history

  4. pass flow

    Sunil Pai committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    e06b72b View commit details
    Browse the repository at this point in the history

  5. dedupe warnings per fiber, nits

    Sunil Pai committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    190e9b1 View commit details
    Browse the repository at this point in the history

  6. better format

    Sunil Pai committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    f37f4fd View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/master' into wrong-hook-order

    Sunil Pai committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    26fd179 View commit details
    Browse the repository at this point in the history

  8. nit

    Sunil Pai committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    3e8a217 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/master' into wrong-hook-order

    Sunil Pai committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    c2d686a View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. fix bad merge, pass flow

    Sunil Pai committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    f493675 View commit details
    Browse the repository at this point in the history

  2. lint

    Sunil Pai committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    a985e72 View commit details
    Browse the repository at this point in the history

  3. missing hooktype enum

    Sunil Pai committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    1621a2d View commit details
    Browse the repository at this point in the history

  4. merge currentHookType/currentHookNameInDev, fix nits

    Sunil Pai committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    5ecda4c View commit details
    Browse the repository at this point in the history

  5. lint

    Sunil Pai committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    d4860ca View commit details
    Browse the repository at this point in the history

  6. final nits

    Sunil Pai committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    3ad6523 View commit details
    Browse the repository at this point in the history