Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #18657 #18663

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Fix for #18657 #18663

merged 2 commits into from
Apr 17, 2020

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Apr 17, 2020

I think this was just poor factoring on my part in #18411. Honestly it doesn't make much sense to me, but my best guess is that I must have thought that when baseTime > currentChildExpirationTime, the function would fall through to the currentChildExpirationTime < renderExpirationTime branch below.

Really I think just made an oopsie.

Regardless, this logic is galaxy brainéd. A goal of the Lanes refactor I'm working on is to make these types of checks — is there remaining work in this tree? — a lot easier to think about. Hopefully.

Fixes #18657

I think this was just poor factoring on my part in facebook#18411. Honestly it
doesn't make much sense to me, but my best guess is that I must have
thought that when `baseTime > currentChildExpirationTime`, the function
would fall through to the
`currentChildExpirationTime < renderExpirationTime` branch below.

Really I think just made an oopsie.

Regardless, this logic is galaxy brainéd. A goal of the Lanes refactor
I'm working on is to make these types of checks -- is there remaining
work in this tree? -- a lot easier to think about. Hopefully.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 17, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b7a0583:

Sandbox Source
tender-bush-0rhsp Configuration
serverless-fog-8u0jt Issue #18657

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c673395:

Sandbox Source
dawn-leaf-4p6lt Configuration
morning-cherry-qbjd5 Issue #18657

@acdlite acdlite requested a review from gaearon April 17, 2020 22:58
@acdlite acdlite marked this pull request as ready for review April 17, 2020 22:58
@sizebot
Copy link

sizebot commented Apr 17, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against c673395

@sizebot
Copy link

sizebot commented Apr 17, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against c673395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Normal update between Idle render and a Ping causes Fallback to get stuck
4 participants